Issue 10821050: add dependancy generatation to generated Makefiles

Issue 10821050: add dependancy generatation to generated Makefiles (Closed)

Created:
8 years, 5 months ago by Sam Clegg

Modified:
8 years, 4 months ago

Reviewers:
binji

CC:
chromium-reviews, pam+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

add dependancy generatation to generated Makefiles This is implemented by passing -MMD to gcc and then including the generated .d files in the Makefile. BUG=139161 TEST= NOTRY=true Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148640

Patch Set 1 #

Patch Set 2 : ' #

Patch Set 3 : rebased against latest #

Total comments: 2

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -19 lines)			Patch
	M	native_client_sdk/src/build_tools/generate_make.py	View	1 2	13 chunks	+18 lines, -15 lines	0 comments	Download
	M	native_client_sdk/src/build_tools/make_rules.py	View	1 2	5 chunks	+6 lines, -4 lines	2 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

Sam Clegg

On 2012/07/26 21:46:48, binji wrote: > lgtm, windows host deps as another CL? Makes sense ...

8 years, 5 months ago (2012-07-26 22:00:07 UTC) #3

binji

On 2012/07/26 22:00:07, Sam Clegg wrote: > On 2012/07/26 21:46:48, binji wrote: > > lgtm, ...

8 years, 5 months ago (2012-07-26 22:03:22 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sbc@chromium.org/10821050/4002

8 years, 5 months ago (2012-07-26 22:48:01 UTC) #5

binji

http://codereview.chromium.org/10821050/diff/4002/native_client_sdk/src/build_tools/make_rules.py File native_client_sdk/src/build_tools/make_rules.py (right): http://codereview.chromium.org/10821050/diff/4002/native_client_sdk/src/build_tools/make_rules.py#newcode35 native_client_sdk/src/build_tools/make_rules.py:35: PNACL_CCFLAGS?=-O0 -g -pthread $(NACL_WARNINGS) whoops, just noticed this... bad ...

8 years, 4 months ago (2012-07-27 18:25:42 UTC) #7

Sam Clegg

8 years, 4 months ago (2012-07-31 16:16:26 UTC) #8

https://chromiumcodereview.appspot.com/10821050/diff/4002/native_client_sdk/s...
File native_client_sdk/src/build_tools/make_rules.py (right):

https://chromiumcodereview.appspot.com/10821050/diff/4002/native_client_sdk/s...
native_client_sdk/src/build_tools/make_rules.py:35: PNACL_CCFLAGS?=-O0 -g
-pthread $(NACL_WARNINGS)
On 2012/07/27 18:25:42, binji wrote:
> whoops, just noticed this... bad merge?

Yup.. looks like it.  How did that happen?  I'll correct right now.

Expand Messages | Collapse Messages