VAVDA: Fix Baseline profile handling in H264 parser.

VAVDA: Fix Baseline profile handling in H264 parser.

This fixes initialization of stream parameters for Baseline profile and
thus the "green-video" bug (135548). Chroma parameters were not being set
up properly for that profile.

BUG=135548
TEST=manual run of affected streams


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148623

[Ami GONE FROM CHROMIUM, 2012-07-26 19:32:12]

LGTM

https://chromiumcodereview.appspot.com/10821043/diff/1/content/common/gpu/med...
File content/common/gpu/media/h264_parser.cc (left):

https://chromiumcodereview.appspot.com/10821043/diff/1/content/common/gpu/med...
content/common/gpu/media/h264_parser.cc:658: memset(sps->scaling_list4x4, 16,
sizeof(sps->scaling_list4x4));
This is pretty awesome; were we setting each int to 
16<<24 | 16<<16 | 16<<8 | 16
instead of just plain
16
?

[Pawel Osciak, 2012-07-26 19:48:49]

https://chromiumcodereview.appspot.com/10821043/diff/1/content/common/gpu/med...
File content/common/gpu/media/h264_parser.cc (left):

https://chromiumcodereview.appspot.com/10821043/diff/1/content/common/gpu/med...
content/common/gpu/media/h264_parser.cc:658: memset(sps->scaling_list4x4, 16,
sizeof(sps->scaling_list4x4));
On 2012/07/26 19:32:12, Ami Fischman wrote:
> This is pretty awesome; were we setting each int to 
> 16<<24 | 16<<16 | 16<<8 | 16
> instead of just plain
> 16
> ?

No, we were casting this to chars later on. But didn't want to leave this here
anyway. Just cleaning up here, the real fix is in ParseSPS() below.

[commit-bot: I haz the power, 2012-07-26 19:51:35]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/posciak@chromium.org/10821043/1

[commit-bot: I haz the power, 2012-07-26 21:11:53]

Change committed as 148623