Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 10821042: Infobar unknown plugins by default on Linux (Closed)

Created:
8 years, 5 months ago by jln (very slow on Chromium)
Modified:
8 years, 4 months ago
CC:
chromium-reviews, darin-cc_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

Infobar unknown plugins by default on Linux The user will be asked for confirmation via an infobar before we let any of the dangerous unknown plugins installed by default on many Linux distributions run. BUG=132679 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148682

Patch Set 1 #

Total comments: 1

Patch Set 2 : Remove useless check for OS_CHROMEOS #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M chrome/browser/renderer_host/plugin_info_message_filter.cc View 1 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
jln (very slow on Chromium)
That should dramatically improve Chrome on Linux security!
8 years, 5 months ago (2012-07-26 22:07:18 UTC) #1
Bernhard Bauer
LGTM https://chromiumcodereview.appspot.com/10821042/diff/1/chrome/browser/renderer_host/plugin_info_message_filter.cc File chrome/browser/renderer_host/plugin_info_message_filter.cc (right): https://chromiumcodereview.appspot.com/10821042/diff/1/chrome/browser/renderer_host/plugin_info_message_filter.cc#newcode163 chrome/browser/renderer_host/plugin_info_message_filter.cc:163: #if defined(OS_LINUX) && !defined(OS_CHROMEOS) Nit: the OS_CHROMEOS check ...
8 years, 5 months ago (2012-07-26 22:10:46 UTC) #2
jln (very slow on Chromium)
Lei, do you mind approving this as OWNER of chrome/ ?
8 years, 5 months ago (2012-07-26 22:27:05 UTC) #3
Lei Zhang
lgtm
8 years, 5 months ago (2012-07-26 22:29:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jln@chromium.org/10821042/1002
8 years, 5 months ago (2012-07-26 22:32:01 UTC) #5
commit-bot: I haz the power
8 years, 5 months ago (2012-07-27 01:03:12 UTC) #6
Change committed as 148682

Powered by Google App Engine
This is Rietveld 408576698