Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 10821039: Removed unnecessary DCHECK on entry (Closed)

Created:
8 years, 5 months ago by Oren Blasberg
Modified:
8 years, 5 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org, gavinp+disk_chromium.org
Visibility:
Public.

Description

Removed unnecessary DCHECK on entry Addresses discussion in code review iossue 10828025. BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148598

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M net/disk_cache/sparse_control.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Oren Blasberg
As rvargas pointed out yesterday, the DCHECK(entry) is unnecessary because this is an internal function ...
8 years, 5 months ago (2012-07-26 17:26:49 UTC) #1
James Hawkins
lgtm
8 years, 5 months ago (2012-07-26 17:35:21 UTC) #2
rvargas (doing something else)
lgtm
8 years, 5 months ago (2012-07-26 17:39:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/orenb@chromium.org/10821039/1
8 years, 5 months ago (2012-07-26 17:40:54 UTC) #4
commit-bot: I haz the power
8 years, 5 months ago (2012-07-26 18:56:01 UTC) #5
Change committed as 148598

Powered by Google App Engine
This is Rietveld 408576698