Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(409)

Side by Side Diff: content/browser/webkit_browsertest.cc

Issue 10821037: Move a number of other tests from browser_tests to content_browsertests. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: a little cleaner Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/browser.h"
6 #include "chrome/browser/ui/browser_tabstrip.h"
7 #include "chrome/test/base/in_process_browser_test.h"
8 #include "chrome/test/base/ui_test_utils.h"
9 #include "content/browser/web_contents/web_contents_impl.h" 5 #include "content/browser/web_contents/web_contents_impl.h"
6 #include "content/public/browser/web_contents.h"
7 #include "content/shell/shell.h"
8 #include "content/test/content_browser_test.h"
9 #include "content/test/content_browser_test_utils.h"
10 #include "content/test/net/url_request_abort_on_end_job.h" 10 #include "content/test/net/url_request_abort_on_end_job.h"
11 11
12 typedef InProcessBrowserTest WebKitBrowserTest; 12 namespace content {
13 13
14 using content::WebContents; 14 typedef ContentBrowserTest WebKitBrowserTest;
15 15
16 const char kAsyncScriptThatAbortsOnEndPage[] = 16 const char kAsyncScriptThatAbortsOnEndPage[] =
17 "files/webkit/async_script_abort_on_end.html"; 17 "files/webkit/async_script_abort_on_end.html";
18 18
19 // This is a browser test because it is hard to reproduce reliably in a 19 // This is a browser test because it is hard to reproduce reliably in a
20 // layout test without races. http://crbug.com/75604 deals with a request 20 // layout test without races. http://crbug.com/75604 deals with a request
21 // for an async script which gets data in the response and immediately 21 // for an async script which gets data in the response and immediately
22 // after aborts. This test creates that condition, and it is passed 22 // after aborts. This test creates that condition, and it is passed
23 // if chrome does not crash. 23 // if chrome does not crash.
24 24
25 IN_PROC_BROWSER_TEST_F(WebKitBrowserTest, AbortOnEnd) { 25 IN_PROC_BROWSER_TEST_F(WebKitBrowserTest, AbortOnEnd) {
26 ASSERT_TRUE(test_server()->Start()); 26 ASSERT_TRUE(test_server()->Start());
27 URLRequestAbortOnEndJob::AddUrlHandler(); 27 URLRequestAbortOnEndJob::AddUrlHandler();
28 GURL url = test_server()->GetURL(kAsyncScriptThatAbortsOnEndPage); 28 GURL url = test_server()->GetURL(kAsyncScriptThatAbortsOnEndPage);
29 29
30 ui_test_utils::NavigateToURL(browser(), url); 30 NavigateToURL(shell(), url);
31 31
32 WebContents* web_contents = chrome::GetActiveWebContents(browser());
33 // If you are seeing this test fail, please strongly investigate the 32 // If you are seeing this test fail, please strongly investigate the
34 // possibility that http://crbug.com/75604 and 33 // possibility that http://crbug.com/75604 and
35 // https://bugs.webkit.org/show_bug.cgi?id=71122 have reverted before 34 // https://bugs.webkit.org/show_bug.cgi?id=71122 have reverted before
36 // marking this as flakey. 35 // marking this as flakey.
37 EXPECT_FALSE(web_contents->IsCrashed()); 36 EXPECT_FALSE(shell()->web_contents()->IsCrashed());
38 } 37 }
39 38
40 // This is a browser test because the DumpRenderTree framework holds 39 // This is a browser test because the DumpRenderTree framework holds
41 // onto a Document* reference that blocks this reproduction from 40 // onto a Document* reference that blocks this reproduction from
42 // destroying the Document, so it is not a use after free unless 41 // destroying the Document, so it is not a use after free unless
43 // you don't have DumpRenderTree loaded. 42 // you don't have DumpRenderTree loaded.
44 43
45 // TODO(gavinp): remove this browser_test if we can get good LayoutTest 44 // TODO(gavinp): remove this browser_test if we can get good LayoutTest
46 // coverage of the same issue. 45 // coverage of the same issue.
47 const char kXsltBadImportPage[] = 46 const char kXsltBadImportPage[] =
48 "files/webkit/xslt-bad-import.html"; 47 "files/webkit/xslt-bad-import.html";
49 IN_PROC_BROWSER_TEST_F(WebKitBrowserTest, XsltBadImport) { 48 IN_PROC_BROWSER_TEST_F(WebKitBrowserTest, XsltBadImport) {
50 ASSERT_TRUE(test_server()->Start()); 49 ASSERT_TRUE(test_server()->Start());
51 URLRequestAbortOnEndJob::AddUrlHandler(); 50 URLRequestAbortOnEndJob::AddUrlHandler();
52 GURL url = test_server()->GetURL(kXsltBadImportPage); 51 GURL url = test_server()->GetURL(kXsltBadImportPage);
53 52
54 ui_test_utils::NavigateToURL(browser(), url); 53 NavigateToURL(shell(), url);
55 54
56 WebContents* web_contents = chrome::GetActiveWebContents(browser()); 55 EXPECT_FALSE(shell()->web_contents()->IsCrashed());
57 EXPECT_FALSE(web_contents->IsCrashed());
58 } 56 }
57
58 } // namespace content
OLDNEW
« no previous file with comments | « content/browser/renderer_host/render_view_host_browsertest.cc ('k') | content/content_tests.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698