[cros] pyauto.CancelOOBEUpdate always returns a non-empty dict with 'next_screen'.

[cros] pyauto.CancelOOBEUpdate always returns a non-empty dict with 'next_screen'.


BUG=None
TEST=chromeos_oobe.py


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148587

[Nirnimesh, 2012-07-25 23:19:49]

Could you update the doc in chrome/test/pyautolib/pyauto.py too please?

[Ivan Korotkov, 2012-07-25 23:22:42]

The doc is already correct because it never mentioned the previous behaviour :)

[Nirnimesh, 2012-07-25 23:23:39]

LGTM. THanks for the fix.

[commit-bot: I haz the power, 2012-07-26 00:54:53]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ivankr@chromium.org/10821031/1

[commit-bot: I haz the power, 2012-07-26 00:54:56]

Presubmit check for 10821031-1 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    chrome/browser/automation

Presubmit checks took 1.1s to calculate.

[Ivan Korotkov, 2012-07-26 00:57:01]

Adding darin@ for OWNERS approval

[darin (slow to review), 2012-07-26 07:00:48]

rubber stamp, LGTM

...but, why is it useful to return a constant value from this IPC?

[Ivan Korotkov, 2012-07-26 16:35:55]

On 2012/07/26 07:00:48, darin wrote:
> rubber stamp, LGTM
> 
> ...but, why is it useful to return a constant value from this IPC?

The reason is that all of these OOBE driving calls have consistent return values
now.

[commit-bot: I haz the power, 2012-07-26 16:36:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ivankr@chromium.org/10821031/1

[commit-bot: I haz the power, 2012-07-26 18:17:20]

Change committed as 148587

[darin (slow to review), 2012-07-26 18:52:30]

OK, thanks for explaining.

On Thu, Jul 26, 2012 at 9:35 AM, <ivankr@chromium.org> wrote:

> On 2012/07/26 07:00:48, darin wrote:
>
>> rubber stamp, LGTM
>>
>
>  ...but, why is it useful to return a constant value from this IPC?
>>
>
> The reason is that all of these OOBE driving calls have consistent return
> values
> now.
>
>
http://codereview.chromium.**org/10821031/<http://codereview.chromium.org/108...
>