Make about:version android friendly.

Make about:version android friendly.

- Moved CSS into shared/css similar to other about pages.
  (cleaned up style warnings during move).
- Added android specific CSS overrides where necessary.
- Removed flash section as it is not supported on Android.

BUG=
TEST=


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148661

[Ted C, 2012-07-25 21:28:01]

And another one :-)

[Evan Stade, 2012-07-26 04:03:10]

lgtm

http://codereview.chromium.org/10821026/diff/1/chrome/browser/resources/about...
File chrome/browser/resources/about_version_android.css (right):

http://codereview.chromium.org/10821026/diff/1/chrome/browser/resources/about...
chrome/browser/resources/about_version_android.css:22: content:
url('../../app/theme/default_100_percent/%DISTRIBUTION%/product_logo.png');
you can avoid the overflow by wrapping before url(

[Ted C, 2012-07-26 17:55:01]

thanks for the review...sadly the wrapping isn't really possible "right" now.

http://codereview.chromium.org/10821026/diff/1/chrome/browser/resources/about...
File chrome/browser/resources/about_version_android.css (right):

http://codereview.chromium.org/10821026/diff/1/chrome/browser/resources/about...
chrome/browser/resources/about_version_android.css:22: content:
url('../../app/theme/default_100_percent/%DISTRIBUTION%/product_logo.png');
On 2012/07/26 04:03:10, Evan Stade wrote:
> you can avoid the overflow by wrapping before url(

It actually goes over by one character if you wrap.  It fits if you wrap after
the url(, but grit doesn't understand that format and will not convert it to the
data: encoded format.

I might be able to get around it with @newt's change to allow no quotes in urls:
http://codereview.chromium.org/10795100/

But that is waiting on a deps roll:
http://codereview.chromium.org/10832017/

I can leave it as is and send you a little clean up CL when that other change
lands.

The other option is that I could change grit to understand the format of
wrapping after the url(, but that will take a bit more effort.

[Ted C, 2012-07-26 18:02:10]

On 2012/07/26 17:55:01, Ted C wrote:
> thanks for the review...sadly the wrapping isn't really possible "right" now.
> 
>
http://codereview.chromium.org/10821026/diff/1/chrome/browser/resources/about...
> File chrome/browser/resources/about_version_android.css (right):
> 
>
http://codereview.chromium.org/10821026/diff/1/chrome/browser/resources/about...
> chrome/browser/resources/about_version_android.css:22: content:
> url('../../app/theme/default_100_percent/%DISTRIBUTION%/product_logo.png');
> On 2012/07/26 04:03:10, Evan Stade wrote:
> > you can avoid the overflow by wrapping before url(
> 
> It actually goes over by one character if you wrap.  It fits if you wrap after
> the url(, but grit doesn't understand that format and will not convert it to
the
> data: encoded format.
> 
> I might be able to get around it with @newt's change to allow no quotes in
urls:
> http://codereview.chromium.org/10795100/
> 
> But that is waiting on a deps roll:
> http://codereview.chromium.org/10832017/
> 
> I can leave it as is and send you a little clean up CL when that other change
> lands.
> 
> The other option is that I could change grit to understand the format of
> wrapping after the url(, but that will take a bit more effort.

Uploading the change to wrap before the url, because it's closer to the format
with the quotes removed, which will fit after grit is rolled.

[commit-bot: I haz the power, 2012-07-26 20:01:40]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tedchoc@chromium.org/10821026/7001

[commit-bot: I haz the power, 2012-07-26 20:01:47]

Presubmit check for 10821026-7001 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Messages **
If this change has an associated bug, add BUG=[bug number].

If this change requires manual test instructions to QA team, add
TEST=[instructions].

** Presubmit Warnings **
Found lines longer than 80 characters (first 5 shown).
  chrome/browser/resources/about_version_android.css, line 23, 81 chars

Presubmit checks took 3.9s to calculate.

[Ted C, 2012-07-26 20:33:34]

On 2012/07/26 20:01:47, I haz the power (commit-bot) wrote:
> Presubmit check for 10821026-7001 failed and returned exit status 1.
> 
> Running presubmit commit checks ...
> 
> ** Presubmit Messages **
> If this change has an associated bug, add BUG=[bug number].
> 
> If this change requires manual test instructions to QA team, add
> TEST=[instructions].
> 
> ** Presubmit Warnings **
> Found lines longer than 80 characters (first 5 shown).
>   chrome/browser/resources/about_version_android.css, line 23, 81 chars
> 
> Presubmit checks took 3.9s to calculate.

DEPS was updated to include the grit changes, so I was able to remove the quotes
and have this work.

[commit-bot: I haz the power, 2012-07-26 20:40:34]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tedchoc@chromium.org/10821026/9001

[commit-bot: I haz the power, 2012-07-26 23:53:34]

Change committed as 148661