Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Issue 10821025: roll gyp 1431:1439 (Closed)

Created:
8 years, 5 months ago by scottmg
Modified:
8 years, 5 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

roll gyp 1431:1439 r1432 Modify RegenerateAppendFlag() to skip duplicate values in environment values r1433 When linking an executable, add the -F options. r1434 Add support for CONFIGURATION_NAME to ninja. r1435 Fixing failing gyp-test-multiple-values. r1436 Make sure OutputDirectory, IntermediateDirectory, and TargetPath have their slashes r1437 ninja windows: support basic generation of manifests at link time r1438 ninja windows: check correct condition for manifest warning r1439 ninja windows: don't use /allowisolation with a .def file TBR=thakis@chromium.org,steveblock@chromium.org,bradnelson@google.com,iannucci@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148509

Patch Set 1 #

Patch Set 2 : 1439 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
scottmg
8 years, 5 months ago (2012-07-25 21:12:01 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/10821025/1
8 years, 5 months ago (2012-07-25 21:12:17 UTC) #2
bradn
lgtm
8 years, 5 months ago (2012-07-25 21:14:52 UTC) #3
iannucci
lgtm
8 years, 5 months ago (2012-07-25 22:11:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/10821025/6003
8 years, 5 months ago (2012-07-25 22:40:12 UTC) #5
commit-bot: I haz the power
8 years, 5 months ago (2012-07-26 03:53:33 UTC) #6
Change committed as 148509

Powered by Google App Engine
This is Rietveld 408576698