Issue 10821019: Add support for mocking failed loads to WebURLLoaderMock.

Issue 10821019: Add support for mocking failed loads to WebURLLoaderMock. (Closed)

Created:
8 years, 5 months ago by japhet%chromium.org

Modified:
8 years, 4 months ago

Reviewers:
tonyg, Nate Chapin

CC:
chromium-reviews, darin-cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Add support for mocking failed loads to WebURLLoaderMock. This is necessary to write a unit test for https://bugs.webkit.org/show_bug.cgi?id=91685 BUG=none TEST=none R=tony Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=149931

Patch Set 1 #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+46 lines, -1 line)			Patch
M	webkit/support/webkit_support.h	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	webkit/support/webkit_support.cc	View	1 chunk	+7 lines, -0 lines	0 comments	Download
M	webkit/support/weburl_loader_mock.cc	View	2 chunks	+6 lines, -0 lines	0 comments	Download
M	webkit/support/weburl_loader_mock_factory.h	View	2 chunks	+8 lines, -0 lines	0 comments	Download
M	webkit/support/weburl_loader_mock_factory.cc	View	3 chunks	+20 lines, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/japhet%chromium.org@gtempaccount.com/10821019/1

8 years, 4 months ago (2012-07-27 18:53:32 UTC) #3

commit-bot: I haz the power

Presubmit check for 10821019-1 failed and returned exit status 1. Running presubmit commit checks ...

8 years, 4 months ago (2012-07-27 18:53:39 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/japhet%chromium.org@gtempaccount.com/10821019/1

8 years, 4 months ago (2012-08-03 21:18:48 UTC) #5

commit-bot: I haz the power

8 years, 4 months ago (2012-08-03 21:18:53 UTC) #6

Presubmit check for 10821019-1 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Warnings **
japhet%chromium.org@gtempaccount.com is not in AUTHORS file. If you are a new
contributor, please visit
http://www.chromium.org/developers/contributing-code and read the "Legal"
section
If you are a chromite, verify the contributor signed the CLA.

Presubmit checks took 1.1s to calculate.

Expand Messages | Collapse Messages