Issue 10821014: Ensure that printer job handler is stopped and task_in_progress_ is reset in OnAuthError

Issue 10821014: Ensure that printer job handler is stopped and task_in_progress_ is reset in OnAuthError (Closed)

Created:
8 years, 5 months ago by Alex Yu

Modified:
8 years, 5 months ago

Reviewers:
Albert Bodenhamer, gene

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Ensure that printer job handler is stopped and task_in_progress_ is reset in OnAuthError BUG=138959 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148485

Patch Set 3 : #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	chrome/service/cloud_print/printer_job_handler.cc	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 11 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alexyu@google.com/10821014/4001

8 years, 5 months ago (2012-07-25 18:44:23 UTC) #2

gene

https://chromiumcodereview.appspot.com/10821014/diff/4001/chrome/service/cloud_print/printer_job_handler.cc File chrome/service/cloud_print/printer_job_handler.cc (right): https://chromiumcodereview.appspot.com/10821014/diff/4001/chrome/service/cloud_print/printer_job_handler.cc#newcode181 chrome/service/cloud_print/printer_job_handler.cc:181: MessageLoop::current()->PostTask( Move to the top of the function? It ...

8 years, 5 months ago (2012-07-25 18:45:43 UTC) #3

Alex Yu

8 years, 5 months ago (2012-07-25 18:51:44 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alexyu@google.com/10821014/2002

8 years, 5 months ago (2012-07-25 20:00:18 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alexyu@google.com/10821014/12001

8 years, 5 months ago (2012-07-25 20:11:36 UTC) #6

commit-bot: I haz the power

Try job failure for 10821014-12001 (retry) on mac_rel for step "browser_tests". It's a second try, ...

8 years, 5 months ago (2012-07-25 21:38:13 UTC) #7

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alexyu@google.com/10821014/12001

8 years, 5 months ago (2012-07-25 21:39:51 UTC) #9

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alexyu@google.com/10821014/3007

8 years, 5 months ago (2012-07-26 00:55:51 UTC) #10

Change committed as 148485

Expand Messages | Collapse Messages