Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Issue 10821011: Add .revisions() implementation to *Checkout classes. (Closed)

Created:
8 years, 4 months ago by M-A Ruel
Modified:
8 years, 4 months ago
Reviewers:
cmp
CC:
chromium-reviews, Dirk Pranke, cmp+cc_chromium.org, M-A Ruel, Roger Tawa OOO till Jul 10th
Visibility:
Public.

Description

Add .revisions() implementation to *Checkout classes. This permits to count the number of check-ins between two revisions. This will be used by the CQ to determine if a try job 'expired', e.g. it is so old that it can't be used anymore. The .revisions() function specifically count the number of commits, instead of just doing arithmetic on the svn revision numbers. R=cmp@chromium.org BUG= TEST=Manually: import checkout s = checkout.SvnCheckout('/path/to/chrome/src', None, None, None, 'svn://svn.chromium.org/chrome/trunk/src') s.revisions(148323, 148330) s.revisions(148323, None) g = checkout.GitCheckout('.', None, 'master') g.revisions('HEAD^^^^^^^^', None) g.revisions('HEAD^^', 'HEAD') Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148546

Patch Set 1 #

Total comments: 2

Patch Set 2 : trap some exceptions #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -0 lines) Patch
M checkout.py View 1 5 chunks +54 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
M-A Ruel
8 years, 4 months ago (2012-07-25 15:42:59 UTC) #1
cmp
lgtm with nit, but wondering about lack of test for this https://chromiumcodereview.appspot.com/10821011/diff/1/checkout.py File checkout.py (right): ...
8 years, 4 months ago (2012-07-25 20:03:01 UTC) #2
M-A Ruel
https://chromiumcodereview.appspot.com/10821011/diff/1/checkout.py File checkout.py (right): https://chromiumcodereview.appspot.com/10821011/diff/1/checkout.py#newcode195 checkout.py:195: return None On 2012/07/25 20:03:01, cmp wrote: > should ...
8 years, 4 months ago (2012-07-25 20:25:03 UTC) #3
cmp
lgtm
8 years, 4 months ago (2012-07-25 20:28:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/10821011/2002
8 years, 4 months ago (2012-07-26 13:19:27 UTC) #5
commit-bot: I haz the power
8 years, 4 months ago (2012-07-26 13:22:52 UTC) #6
Change committed as 148546

Powered by Google App Engine
This is Rietveld 408576698