Automatically support fancy Console methods.

lib/dom/scripts/systemnative.py

 #!/usr/bin/python
 # Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 # for details. All rights reserved. Use of this source code is governed by a
 # BSD-style license that can be found in the LICENSE file.
 
 """This module provides shared functionality for the systems to generate
 native binding from the IDL database."""
 
 import emitter
 import os
@@ skipping 661 matching lines @@
     if raises_dom_exception or arguments:
       raises_exceptions = True
 
     if ext_attrs.get('CallWith') == 'ScriptArguments|CallStack':
       raises_exceptions = True
       requires_v8_scope = True
       requires_stack_info = True
       self._cpp_impl_includes.add('"ScriptArguments.h"')
       self._cpp_impl_includes.add('"ScriptCallStack.h"')
       cpp_arguments = ['scriptArguments', 'scriptCallStack']
+      # WebKit uses scriptArguments to reconstruct last argument, so
+      # it's not needed and should be just removed.
+      arguments = arguments[:-1]

[podivilov, 2012/08/21 12:03:27]

It does the opposite to DatabaseBuilder.AddMissingArguments, right? Could you
please remove both hacks instead?

[Anton Muhin, 2012/08/21 12:04:33]

I'd be glad to, but I need proper signatures for all the backends and interface
generators.

On 2012/08/21 12:03:27, podivilov wrote:

 
     if ext_attrs.get('CallWith') == 'ScriptExecutionContext':
       raises_exceptions = True
       requires_script_execution_context = True
       cpp_arguments = ['context']
 
     if 'ImplementedBy' in ext_attrs:
       assert needs_receiver
+      self._cpp_impl_includes.add('"%s.h"' % ext_attrs['ImplementedBy'])
       cpp_arguments.append('receiver')
-      self._cpp_impl_includes.add('"%s.h"' % ext_attrs['ImplementedBy'])
 
     if 'NamedConstructor' in ext_attrs:
       raises_exceptions = True
       requires_dom_window = True
       self._cpp_impl_includes.add('"DOMWindow.h"')
       cpp_arguments = ['document']
 
     if 'Reflect' in ext_attrs:
       cpp_arguments = [self._GenerateWebCoreReflectionAttributeName(node)]
 
@@ skipping 83 matching lines @@
     if requires_stack_info:
       body_emitter.Emit(
           '\n'
           '        Dart_Handle customArgument = Dart_GetNativeArgument(args, $INDEX);\n'
           '        RefPtr<ScriptArguments> scriptArguments(DartUtilities::createScriptArguments(customArgument, exception));\n'
           '        if (!scriptArguments)\n'
           '            goto fail;\n'
           '        RefPtr<ScriptCallStack> scriptCallStack(DartUtilities::createScriptCallStack());\n'
           '        if (!scriptCallStack->size())\n'
           '            return;\n',
-          INDEX=len(arguments))
+          INDEX=len(arguments) + 1)
 
     # Process Dart cpp_arguments.
-    start_index = 0
-    if needs_receiver:
-      start_index = 1
-    for (i, argument) in enumerate(arguments):
-      if (i == len(arguments) - 1 and
-          self._interface.id == 'Console' and
-          argument.id == 'arg'):
-        # FIXME: we are skipping last argument here because it was added in
-        # supplemental dart.idl. Cleanup dart.idl and remove this check.
-        break
+    start_index = 1 if needs_receiver else 0
+    for i, argument in enumerate(arguments):
       argument_expression = self._GenerateToNative(body_emitter, argument, start_index + i)
       cpp_arguments.append(argument_expression)
 
     body_emitter.Emit('\n')
 
     # FIXME: rework in IDLs.
     if node.id in ['addEventListener', 'removeEventListener']:
       # addEventListener's and removeEventListener's last argument is marked
       # as optional in idl, but is not optional in webcore implementation.
       if len(arguments) == 2:
@@ skipping 114 matching lines @@
 
 def _IsArgumentOptionalInWebCore(argument):
   return IsOptional(argument) and not 'Callback' in argument.ext_attrs
 
 def _ToWebKitName(name):
   name = name[0].lower() + name[1:]
   name = re.sub(r'^(hTML|uRL|jS|xML|xSLT)', lambda s: s.group(1).lower(),
                 name)
   return re.sub(r'^(create|exclusive)', lambda s: 'is' + s.group(1).capitalize(),
                 name)