Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 10821009: Add the CoreGraphics and CoreText frameworks to base for iOS (Closed)

Created:
8 years, 5 months ago by stuartmorgan
Modified:
8 years, 5 months ago
Reviewers:
qsr
CC:
chromium-reviews, erikwright (departed), brettw-cc_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Add the CoreGraphics and CoreText frameworks to base for iOS r147862 added dependencies on CoreText and CoreGraphics to foundation_utils, so those frameworks now need to be linked on iOS. TBR= BUG=None TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148307

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M base/base.gyp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
stuartmorgan
8 years, 5 months ago (2012-07-25 05:43:14 UTC) #1
qsr
lgtm
8 years, 5 months ago (2012-07-25 07:38:37 UTC) #2
stuartmorgan
TBRing for OWNERs per previous discussion with Mark, since it's a trivial iOS-only change.
8 years, 5 months ago (2012-07-25 07:41:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stuartmorgan@chromium.org/10821009/1
8 years, 5 months ago (2012-07-25 07:41:09 UTC) #4
commit-bot: I haz the power
8 years, 5 months ago (2012-07-25 11:07:46 UTC) #5
Change committed as 148307

Powered by Google App Engine
This is Rietveld 408576698