Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(532)

Issue 10821006: Add new content settings icons (Closed)

Created:
8 years, 5 months ago by markusheintz_
Modified:
8 years, 5 months ago
Reviewers:
battre
CC:
chromium-reviews, oshima+watch_chromium.org, Patrick Dubroy
Visibility:
Public.

Description

Add new content settings icons BUG=113688 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=148344

Patch Set 1 #

Patch Set 2 : Add missing 200% version of ask_media.png #

Patch Set 3 : Add block_media icon. #

Patch Set 4 : Fix filenames. #

Patch Set 5 : " #

Unified diffs Side-by-side diffs Delta from patch set Stats (+-25 lines, --25 lines) Patch
A chrome/app/theme/default_100_percent/allowed_fullscreen.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/app/theme/default_100_percent/allowed_images.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/app/theme/default_100_percent/allowed_mouse_cursor.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/app/theme/default_100_percent/allowed_notifications.png View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/app/theme/default_100_percent/allowed_plugins.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/app/theme/default_100_percent/allowed_popups.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/app/theme/default_100_percent/allowed_script.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/app/theme/default_100_percent/ask_media.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/app/theme/default_100_percent/blocked_fullscreen.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/app/theme/default_100_percent/blocked_media.png View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/app/theme/default_100_percent/blocked_mouse_cursor.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/app/theme/default_100_percent/blocked_notifications.png View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/app/theme/default_100_percent/blocked_script.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/app/theme/default_200_percent/allowed_fullscreen.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/app/theme/default_200_percent/allowed_images.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/app/theme/default_200_percent/allowed_mouse_cursor.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/app/theme/default_200_percent/allowed_notifications.png View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/app/theme/default_200_percent/allowed_plugins.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/app/theme/default_200_percent/allowed_popups.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/app/theme/default_200_percent/allowed_script.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/app/theme/default_200_percent/ask_media.png View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/app/theme/default_200_percent/blocked_fullscreen.png View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/app/theme/default_200_percent/blocked_media.png View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/app/theme/default_200_percent/blocked_mouse_cursor.png View 1 2 3 4 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/app/theme/default_200_percent/blocked_notifications.png View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
markusheintz_
Please review this CL. Thanks
8 years, 5 months ago (2012-07-25 00:49:14 UTC) #1
markusheintz_
Add Dominic as reviewer as he is in my time zone. Dominic could you review ...
8 years, 5 months ago (2012-07-25 09:58:45 UTC) #2
battre
lgtm
8 years, 5 months ago (2012-07-25 11:59:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/markusheintz@chromium.org/10821006/7005
8 years, 5 months ago (2012-07-25 13:46:41 UTC) #4
commit-bot: I haz the power
Presubmit check for 10821006-7005 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 5 months ago (2012-07-25 13:46:50 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/markusheintz@chromium.org/10821006/3009
8 years, 5 months ago (2012-07-25 14:58:02 UTC) #6
commit-bot: I haz the power
8 years, 5 months ago (2012-07-25 14:58:14 UTC) #7
Presubmit check for 10821006-3009 failed and returned exit status 1.

Running presubmit commit checks ...
Traceback (most recent call last):
  File "/b/commit-queue/verification/presubmit_shim.py", line 43, in <module>
    sys.exit(presubmit_support.Main(argv))
  File "/b/depot_tools/presubmit_support.py", line 1257, in Main
    rietveld_obj)
  File "/b/depot_tools/presubmit_support.py", line 1105, in DoPresubmitChecks
    results += executer.ExecPresubmitScript(presubmit_script, filename)
  File "/b/depot_tools/presubmit_support.py", line 1022, in ExecPresubmitScript
    result = eval(function_name + '(*__args)', context)
  File "<string>", line 1, in <module>
  File "<string>", line 19, in CheckChangeOnCommit
  File "<string>", line 44, in _CommonChecks
  File
"/b/commit-queue/workdir/chromium/chrome/app/theme/../../../ui/resources/resource_check/resource_scale_factors.py",
line 83, in RunChecks
    base_width, base_height = ImageSize(base_image)
  File
"/b/commit-queue/workdir/chromium/chrome/app/theme/../../../ui/resources/resource_check/resource_scale_factors.py",
line 47, in ImageSize
    assert data[:8] == '\x89PNG\r\n\x1A\n' and data[12:16] == 'IHDR'
AssertionError

Powered by Google App Engine
This is Rietveld 408576698