Convenience script to update a submodule-based checkout.

Convenience script to update a submodule-based checkout.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148973

[M-A Ruel, 2012-07-27 19:59:07]

Is this supposed to be run by users? I'm not a fan of bash script, if you prefer
to keep it as a bash file, you can ask Chase to review it, as I don't master
bash that much.

[szager, 2012-07-27 21:09:01]

On 2012/07/27 19:59:07, Marc-Antoine Ruel wrote:
> Is this supposed to be run by users? I'm not a fan of bash script, if you
prefer
> to keep it as a bash file, you can ask Chase to review it, as I don't master
> bash that much.

I want it to be as git-ish as possible, which means bash.  I also want to make
it exceedingly simple for users to see what scripts are doing, and be able to
reproduce their constituent steps, which also means bash.  So, yes, this is for
users, and the language choice was deliberate.

[szager1, 2012-07-30 16:56:34]

ping

[cmp, 2012-07-30 17:22:03]

lgtm, but a couple comments below

this contains the xargs -P approach to run submodule fetch in parallel.  is your
end goal to integrate that with git-submodule upstream and simplify this script?

do you consider git-submodule missing the functionality to call a hook after all
of the submodules are sync'ed, and this script just a placeholder for that if it
ever appears upstream?

https://chromiumcodereview.appspot.com/10820057/diff/1/git-cr-sync
File git-cr-sync (right):

https://chromiumcodereview.appspot.com/10820057/diff/1/git-cr-sync#newcode2
git-cr-sync:2: 
can you add a brief comment at the top of the file describing the purpose of the
script?

https://chromiumcodereview.appspot.com/10820057/diff/1/git-cr-sync#newcode11
git-cr-sync:11: Usage: git-cr-sync [-n|--dry-run] [--fetch] [-j|--jobs [jobs]]
git-crsync would avoid an extra trip to the dash symbol on the keyboard. 
git-crup shaves 2 more keys off.  How about git-crup?

[szager1, 2012-07-30 17:49:48]

On 2012/07/30 17:22:03, cmp wrote:
> lgtm, but a couple comments below
> 
> this contains the xargs -P approach to run submodule fetch in parallel.  is
your
> end goal to integrate that with git-submodule upstream and simplify this
script?

Yep, I'm working with the git folks on a separate patch to git to support this. 
They are amenable.

> do you consider git-submodule missing the functionality to call a hook after
all
> of the submodules are sync'ed, and this script just a placeholder for that if
it
> ever appears upstream?

Yes, that's definitely a shortcoming which I plan to address upstream.  I
haven't started on that yet, because there are probably a couple of other places
where hooks are missing (like post-rebase), and I want to bundle the work
together.

[szager1, 2012-07-30 17:49:57]

https://chromiumcodereview.appspot.com/10820057/diff/1/git-cr-sync
File git-cr-sync (right):

https://chromiumcodereview.appspot.com/10820057/diff/1/git-cr-sync#newcode2
git-cr-sync:2: 
On 2012/07/30 17:22:04, cmp wrote:
> can you add a brief comment at the top of the file describing the purpose of
the
> script?

Done.

https://chromiumcodereview.appspot.com/10820057/diff/1/git-cr-sync#newcode11
git-cr-sync:11: Usage: git-cr-sync [-n|--dry-run] [--fetch] [-j|--jobs [jobs]]
On 2012/07/30 17:22:04, cmp wrote:
> git-crsync would avoid an extra trip to the dash symbol on the keyboard. 
> git-crup shaves 2 more keys off.  How about git-crup?

Done.

[commit-bot: I haz the power, 2012-07-30 17:50:35]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/szager@chromium.org/10820057/6001

[commit-bot: I haz the power, 2012-07-30 17:53:20]

Change committed as 148973