Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Unified Diff: runtime/vm/assembler_x64.h

Issue 10820053: Fix kStoreBufferBlockProcessRuntimeEntry call sequence. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: always restore stack pointer Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/assembler_x64.h
diff --git a/runtime/vm/assembler_x64.h b/runtime/vm/assembler_x64.h
index 67c5a252ab67974a16b56ed7722745f9fed0df55..eef61110e30a84cdf1c1c77671849e40db7f8218 100644
--- a/runtime/vm/assembler_x64.h
+++ b/runtime/vm/assembler_x64.h
@@ -558,9 +558,12 @@ class Assembler : public ValueObject {
void LeaveFrame();
void ReserveAlignedFrameSpace(intptr_t frame_space);
- // Preserve and restore caller save registers according to the C ABI.
- void PreserveCallerSavedRegisters();
- void RestoreCallerSavedRegisters();
+ // Create a frame for calling into runtime that preserves all volatile
+ // registers. Frame's RSP is guaranteed to be correctly aligned and
+ // frame_space bytes are reserved under it.
+ void EnterCallRuntimeFrame(intptr_t frame_space);
+ void LeaveCallRuntimeFrame();
+
void CallRuntime(const RuntimeEntry& entry);

Powered by Google App Engine
This is Rietveld 408576698