Fix kStoreBufferBlockProcessRuntimeEntry call sequence.

runtime/vm/assembler_ia32.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/globals.h"
 #if defined(TARGET_ARCH_IA32)
 
 #include "vm/assembler.h"
 #include "vm/heap.h"
 #include "vm/memory_region.h"
@@ skipping 1507 matching lines @@
 void Assembler::ReserveAlignedFrameSpace(intptr_t frame_space) {
   // Reserve space for arguments and align frame before entering
   // the C++ world.
   AddImmediate(ESP, Immediate(-frame_space));
   if (OS::ActivationFrameAlignment() > 0) {
     andl(ESP, Immediate(~(OS::ActivationFrameAlignment() - 1)));
   }
 }
 
 
-void Assembler::PreserveCallerSavedRegisters() {
+void Assembler::EnterCallRuntimeFrame(intptr_t frame_space) {
+  enter(Immediate(0));
+
+  // Preserve volatile registers.

[siva, 2012/07/27 20:41:21]

ASSERT(kNumberOfVolatileRegisters == 3);
or better still generate some assembly code similar to CHECK_STACK_ALIGNMENT
which would in debug mode ensure that EBP - ESP is (kNumberOfVolatileRegisters *
kWordSize);

   pushl(EAX);
   pushl(ECX);
   pushl(EDX);
+
+  ReserveAlignedFrameSpace(frame_space);
 }
 
 
-void Assembler::RestoreCallerSavedRegisters() {
+void Assembler::LeaveCallRuntimeFrame() {
+  // ESP might have been modified to reserve space for arguments
+  // and ensure proper alignment of the stack frame.
+  // We need to restore it before restoring registers.
+  const intptr_t kNumberOfVolatileRegisters = 3;

[siva, 2012/07/27 20:41:21]

Pull this to the class so that it is accessible from EnterCallRuntimeFrame also.

+  leal(ESP, Address(EBP, -kNumberOfVolatileRegisters * kWordSize));
+
+  // Restore volatile registers.

[siva, 2012/07/27 20:41:21]

ASSERT(kNumberofVolatileRegisters == 3);

   popl(EDX);
   popl(ECX);
   popl(EAX);
+
+  leave();
 }
 
 
 void Assembler::CallRuntime(const RuntimeEntry& entry) {
   entry.Call(this);
 }
 
 
 void Assembler::Align(int alignment, int offset) {
   ASSERT(Utils::IsPowerOfTwo(alignment));
@@ skipping 216 matching lines @@
 
 const char* Assembler::RegisterName(Register reg) {
   ASSERT((0 <= reg) && (reg < kNumberOfCpuRegisters));
   return cpu_reg_names[reg];
 }
 
 
 }  // namespace dart
 
 #endif  // defined TARGET_ARCH_IA32