Add OS_IOS defines for the mobile promo.

Add OS_IOS defines for the mobile promo.

Enable the mobile_ntp_sync_promo on iOS. Add corresponding ifdefs.

BUG=NONE
TEST=NONE


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149166

[aruslan1, 2012-07-27 14:58:47]

LGTM, please do not forget to add tablet vs phone code once relevant parts are
upstreamed.

[noyau (Ping after 24h), 2012-07-27 15:00:26]

On 2012/07/27 14:58:47, aruslan1 wrote:
> LGTM, please do not forget to add tablet vs phone code once relevant parts are
> upstreamed.
Yes, as soon as the header we use is brought up we will upstream that small
change.

[msarda, 2012-07-27 15:24:07]

We rediscussed this internally and we prefer not to upstream the entire change
for now. We need these accessors to avoid parsing the promo dictionary from
preferences.
PTAL.

[aruslan, 2012-07-27 18:18:14]

https://chromiumcodereview.appspot.com/10820048/diff/5002/chrome/browser/web_...
File chrome/browser/web_resource/notification_promo.h (right):

https://chromiumcodereview.appspot.com/10820048/diff/5002/chrome/browser/web_...
chrome/browser/web_resource/notification_promo.h:58: base::ListValue*
promo_action_args() const {
could it be a const base::ListValue* (I guess const_cast would be necessary)?

[aruslan, 2012-07-27 18:23:35]

LGTM.

https://chromiumcodereview.appspot.com/10820048/diff/5002/chrome/browser/web_...
File chrome/browser/web_resource/notification_promo.h (right):

https://chromiumcodereview.appspot.com/10820048/diff/5002/chrome/browser/web_...
chrome/browser/web_resource/notification_promo.h:61: #endif  //
defined(OS_ANDROID) ||  defined(OS_IOS)
nit: extra space before defined(OS_IOS)

[msarda, 2012-07-30 08:41:51]

@Achuith: PTAL.

https://chromiumcodereview.appspot.com/10820048/diff/5002/chrome/browser/web_...
File chrome/browser/web_resource/notification_promo.h (right):

https://chromiumcodereview.appspot.com/10820048/diff/5002/chrome/browser/web_...
chrome/browser/web_resource/notification_promo.h:58: base::ListValue*
promo_action_args() const {
On 2012/07/27 18:18:15, aruslan wrote:
> could it be a const base::ListValue* (I guess const_cast would be necessary)?

Done (I think that the static_cast is not needed - simply casting to const).

https://chromiumcodereview.appspot.com/10820048/diff/5002/chrome/browser/web_...
chrome/browser/web_resource/notification_promo.h:61: #endif  //
defined(OS_ANDROID) ||  defined(OS_IOS)
On 2012/07/27 18:23:35, aruslan wrote:
> nit: extra space before defined(OS_IOS)

Done.

[achuithb, 2012-07-30 18:15:44]

http://codereview.chromium.org/10820048/diff/7001/chrome/browser/web_resource...
File chrome/browser/web_resource/notification_promo.h (right):

http://codereview.chromium.org/10820048/diff/7001/chrome/browser/web_resource...
chrome/browser/web_resource/notification_promo.h:54: std::string promo_text()
const { return promo_text_; }
Could you make all the return types const references? 
const std::string&

[msarda, 2012-07-31 07:29:59]

PTAL.

https://chromiumcodereview.appspot.com/10820048/diff/7001/chrome/browser/web_...
File chrome/browser/web_resource/notification_promo.h (right):

https://chromiumcodereview.appspot.com/10820048/diff/7001/chrome/browser/web_...
chrome/browser/web_resource/notification_promo.h:54: std::string promo_text()
const { return promo_text_; }
On 2012/07/30 18:15:44, achuith.bhandarkar wrote:
> Could you make all the return types const references? 
> const std::string&

Done.

[achuithb, 2012-07-31 09:17:40]

lgtm

[commit-bot: I haz the power, 2012-07-31 09:40:08]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/msarda@chromium.org/10820048/5004

[commit-bot: I haz the power, 2012-07-31 11:01:32]

Change committed as 149166