src/elements.cc - Issue 10820047: Make sure double to int conversion is correct.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/elements.cc

Issue 10820047: Make sure double to int conversion is correct. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: addressed comments. Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/elements.cc

diff --git a/src/elements.cc b/src/elements.cc

index f0e1414de4aeebe9ef9089ecd2b1cc5fc6f1b682..4cb50a461d4a69790e70d2d5d5795e874fe7b99b 100644

--- a/src/elements.cc

+++ b/src/elements.cc

@@ -800,7 +800,7 @@ class FastElementsAccessor

}

} else {

// Otherwise, fill the unused tail with holes.

- int old_length = FastD2I(array->length()->Number());

+ int old_length = FastD2IChecked(array->length()->Number());

for (int i = length; i < old_length; i++) {

backing_store->set_the_hole(i);

}

« no previous file with comments | « src/conversions.h ('k') | src/runtime.cc » ('j') | no next file with comments »