Issue 10820042: Uses DCHECK_GT() instead of DCHECK_LE().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10820042: Uses DCHECK_GT() instead of DCHECK_LE(). (Closed)

Created:
8 years, 5 months ago by Kyle Horimoto

Modified:
8 years, 5 months ago

Reviewers:
Peter Kasting

CC:
chromium-reviews, feature-media-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Uses DCHECK_GT() instead of DCHECK_LE(). BUG= TEST= TBR=tommi Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148683

Patch Set 1 #

Patch Set 2 : Rebased #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	media/audio/win/wavein_input_win.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/khorimoto@chromium.org/10820042/1

8 years, 5 months ago (2012-07-26 23:31:42 UTC) #3

commit-bot: I haz the power

Failed to apply patch for media/audio/win/wavein_input_win.cc: While running patch -p1 --forward --force; patching file media/audio/win/wavein_input_win.cc ...

8 years, 5 months ago (2012-07-26 23:31:44 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/khorimoto@chromium.org/10820042/2002

8 years, 5 months ago (2012-07-26 23:33:56 UTC) #5

Change committed as 148683

Expand Messages | Collapse Messages