Chromium Code Reviews Chromium Code Reviews
Issue 10820031:
Modifications to performance monitor UI to address real webui. (Closed)
Base URL: http://git.chromium.org/chromium/src.git@master| Index: chrome/browser/resources/performance_monitor/chart.html |
| diff --git a/chrome/browser/resources/performance_monitor/chart.html b/chrome/browser/resources/performance_monitor/chart.html |
| index e77dd4e39955062b37b72e237ecf13012f30f389..38d2e2888a51e778a2d3ea5eea707486e1c74c8c 100644 |
| --- a/chrome/browser/resources/performance_monitor/chart.html |
| +++ b/chrome/browser/resources/performance_monitor/chart.html |
| @@ -7,14 +7,14 @@ found in the LICENSE file. --> |
| <!-- This page uses Flot version 0.7 in compressed form for efficiency. |
| Readable Flot source is available at http://code.google.com/p/flot/ |
| Good caliber Flot API docs are at: http://people.iola.dk/olau/flot/API.txt |
| -as of 6/2012 --> |
| +as of 6/2012.--> |
|
Dan Beam
2012/08/03 18:40:36
. --> (needs a space)
clintstaley
2012/08/06 21:06:47
Done.
|
| <html> |
| <head> |
| - <script type="text/javascript" |
| - src="../../../../third_party/flot/jquery.min.js"></script> |
| - <script type="text/javascript" |
| - src="../../../../third_party/flot/jquery.flot.min.js"></script> |
| + <script src="chrome://resources/js/cr.js"></script> |
| + <script src="chrome://resources/js/util.js"></script> |
| + <script type="text/javascript" src="jquery.js"></script> |
|
Dan Beam
2012/08/03 18:40:36
I think you should omit [type] here or be consiste
clintstaley
2012/08/06 21:06:47
Done.
|
| + <script type="text/javascript" src="flot.js"></script> |
| <link rel="stylesheet" type="text/css" href="chart.css"/> |
| </head> |
| <body> |
| @@ -25,12 +25,13 @@ as of 6/2012 --> |
| <div id="chooseEvents"> |
| <h2>Choose Events</h2> |
| </div> |
| + <div class="spacer"></div> |
| <div id="chooseTimeRange"> |
| <h2>Choose Time Range</h2> |
| </div> |
| </div> |
| <div id="charts"></div> |
| - <div id="templates" class="hidden"> |
| + <div id="templates" hidden> |
| <div id="labelTemplate" class="event-label"></div> |
| <div id="checkboxTemplate" class="checkbox"> |
| <label> |
