Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6836)

Unified Diff: chrome/browser/resources/performance_monitor/chart.css

Issue 10820031: Modifications to performance monitor UI to address real webui. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Revision with all latest changes Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/performance_monitor/chart.css
diff --git a/chrome/browser/resources/performance_monitor/chart.css b/chrome/browser/resources/performance_monitor/chart.css
index a7aa65679b1ad364155d0b989f5eb51bcf12aa13..f17de7856036dba593c425d407b0802fc2b63e83 100644
--- a/chrome/browser/resources/performance_monitor/chart.css
+++ b/chrome/browser/resources/performance_monitor/chart.css
@@ -2,41 +2,33 @@
* Use of this source code is governed by a BSD-style license that can be
* found in the LICENSE file. */
-div#chooseMetrics {
- float: left;
+#chooseBlock {
Dan Beam 2012/08/03 18:40:36 the style guide says this should be #choose-block
clintstaley 2012/08/06 21:06:47 Sorry. Changed here and elsewhere.
+ -webkit-box-orient: horizontal;
+ background: #eee;
+ display: -webkit-box;
}
-div#chooseEvents {
- float: left;
- margin-left: 20px;
+.spacer {
+ -webkit-box-flex: 1;
}
-div#chooseTimeRange {
- float: right;
+/* Style for div enclosing all charts, collectively. Increase these
+ * dimensions if you redesign for more than one chart.*/
Dan Beam 2012/08/03 18:40:36 some people prefer not to use "we" or "you" in com
clintstaley 2012/08/06 21:06:47 Can change it if you really feel strongly, but my
Evan Stade 2012/08/07 00:46:35 I don't care about the use of pronouns but it's pr
+#charts {
+ height: 500px;
+ width: 900px;
}
-div#chooseBlock {
- background: #eee;
- overflow: hidden;
-}
-
-div#charts {
- height: 500px;
- width: 900px;
-}
-
-div.chart {
- height: 500px;
- width: 900px;
+/* Style for any div that encloses a single chart -- a child div of the
+ * larger #charts div.*/
+.chart {
Dan Beam 2012/08/03 18:40:36 why can't these two rules be combined until they d
clintstaley 2012/08/06 21:06:47 Done.
+ height: 500px;
+ width: 900px;
}
div.event-label {
- background: #fff;
- border: 1px solid;
- font: 0.6em;
- position: absolute;
-}
-
-.hidden {
- visibility: hidden;
+ background: white;
+ border: 1px solid;
+ font: 0.6em;
+ position: absolute;
}

Powered by Google App Engine
This is Rietveld 408576698