Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(392)

Issue 10820029: Roll WebKit to r123712 (Closed)

Created:
8 years, 4 months ago by tomhudson
Modified:
8 years, 4 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews, Zhenyao Mo
Visibility:
Public.

Description

Roll WebKit to r123712. TBR=pkasting@chromium.org BUG=none PATCH=none Originally tried r123710 since Mac browser_tests were known green then, but Windows + Android need the build fix at x712. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=148619

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
tomhudson
Since we don't do git here, I can't use safely-roll-webkit.py; let's see if this works.
8 years, 4 months ago (2012-07-26 13:08:26 UTC) #1
tomhudson
Looks like we need to correct the panScroll-click-hyperlink failure on Windows.
8 years, 4 months ago (2012-07-26 15:09:44 UTC) #2
tomhudson
That failure began immediately after (or with) the previous roll: http://build.chromium.org/p/chromium.webkit/builders/Webkit%20Win%20%28deps%29/builds/20331
8 years, 4 months ago (2012-07-26 15:13:11 UTC) #3
commit-bot: I haz the power
No reviewers yet.
8 years, 4 months ago (2012-07-26 16:25:04 UTC) #4
commit-bot: I haz the power
No reviewers yet.
8 years, 4 months ago (2012-07-26 16:29:22 UTC) #5
commit-bot: I haz the power
No reviewers yet.
8 years, 4 months ago (2012-07-26 16:30:12 UTC) #6
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
8 years, 4 months ago (2012-07-26 16:31:50 UTC) #7
Andrew T Wilson (Slow)
LGTM
8 years, 4 months ago (2012-07-26 16:34:29 UTC) #8
commit-bot: I haz the power
8 years, 4 months ago (2012-07-26 16:34:50 UTC) #9

Powered by Google App Engine
This is Rietveld 408576698