Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1323)

Unified Diff: chrome/browser/ui/omnibox/omnibox_view_browsertest.cc

Issue 10820022: Disable SelectAllOnClick to unbreak tree. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/omnibox/omnibox_view_browsertest.cc
diff --git a/chrome/browser/ui/omnibox/omnibox_view_browsertest.cc b/chrome/browser/ui/omnibox/omnibox_view_browsertest.cc
index 203b46eef97dc66e49e4ca4a32f8527b56b3947a..e7b2905f9eb561cf2197fadd85ad4cdd772b2a22 100644
--- a/chrome/browser/ui/omnibox/omnibox_view_browsertest.cc
+++ b/chrome/browser/ui/omnibox/omnibox_view_browsertest.cc
@@ -1613,7 +1613,7 @@ IN_PROC_BROWSER_TEST_F(OmniboxViewTest, MAYBE_PasteReplacingAll) {
// TODO(derat): Enable on Windows: http://crbug.com/128556
#if defined(USE_AURA)
-IN_PROC_BROWSER_TEST_F(OmniboxViewTest, SelectAllOnClick) {
+IN_PROC_BROWSER_TEST_F(OmniboxViewTest, DISABLED_SelectAllOnClick) {
OmniboxView* omnibox_view = NULL;
ASSERT_NO_FATAL_FAILURE(GetOmniboxView(&omnibox_view));
omnibox_view->SetUserText(ASCIIToUTF16("http://www.google.com/"));
@@ -1642,6 +1642,9 @@ IN_PROC_BROWSER_TEST_F(OmniboxViewTest, SelectAllOnClick) {
// have the effect of re-selecting the text.
ASSERT_NO_FATAL_FAILURE(
ClickFocusViewOrigin(ui_controls::LEFT, kClickOffset, kClickOffset));
+ // The following expect fails starting with one of the cls (148415-148428),
+ // most likely the WebKit roll @148419.
+ // http://crbug.com/139069
EXPECT_TRUE(omnibox_view->IsSelectAll());
EXPECT_TRUE(GetFocusView()->HasFocus());
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698