Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issue 10820016: Fix dead code bug in ParseSEI (Closed)

Created:
8 years, 5 months ago by Tyler Breisacher (Chromium)
Modified:
8 years, 5 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, apatrick_chromium, feature-media-reviews_chromium.org
Visibility:
Public.

Description

Fix dead code bug in ParseSEI CID=104194 BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148590

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M content/common/gpu/media/h264_parser.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Tyler Breisacher (Chromium)
Coverity flagged this as "dead code" -- 'byte' cannot be 0xff at the beginning of ...
8 years, 5 months ago (2012-07-25 18:57:29 UTC) #1
Pawel Osciak
LGTM. Thanks for spotting and fixing!
8 years, 5 months ago (2012-07-26 05:35:22 UTC) #2
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
8 years, 5 months ago (2012-07-26 17:03:54 UTC) #3
Ami GONE FROM CHROMIUM
lgtm
8 years, 5 months ago (2012-07-26 17:04:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tbreisacher@chromium.org/10820016/1
8 years, 5 months ago (2012-07-26 17:04:36 UTC) #5
commit-bot: I haz the power
8 years, 5 months ago (2012-07-26 18:34:05 UTC) #6
Change committed as 148590

Powered by Google App Engine
This is Rietveld 408576698