Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Side by Side Diff: utils/compiler/buildbot.py

Issue 10820015: Remove extra paren. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 #!/usr/bin/python 1 #!/usr/bin/python
2 2
3 # Copyright (c) 2011 The Chromium Authors. All rights reserved. 3 # Copyright (c) 2011 The Chromium Authors. All rights reserved.
4 # Use of this source code is governed by a BSD-style license that can be 4 # Use of this source code is governed by a BSD-style license that can be
5 # found in the LICENSE file. 5 # found in the LICENSE file.
6 6
7 """Dart frog buildbot steps 7 """Dart frog buildbot steps
8 8
9 Runs tests for the frog or dart2js compiler. 9 Runs tests for the frog or dart2js compiler.
10 """ 10 """
(...skipping 202 matching lines...) Expand 10 before | Expand all | Expand 10 after
213 # Windows. 213 # Windows.
214 path_dict = {'ff': os.path.join('C:/', 'Program Files (x86)', 214 path_dict = {'ff': os.path.join('C:/', 'Program Files (x86)',
215 'Mozilla Firefox', 'firefox.exe'), 215 'Mozilla Firefox', 'firefox.exe'),
216 'chrome': os.path.join('C:/', 'Users', 'chrome-bot', 'AppData', 216 'chrome': os.path.join('C:/', 'Users', 'chrome-bot', 'AppData',
217 'Local', 'Google', 'Chrome', 'Application', 'chrome.exe')} 217 'Local', 'Google', 'Chrome', 'Application', 'chrome.exe')}
218 return path_dict[runtime] 218 return path_dict[runtime]
219 219
220 if system == 'linux' and runtime == 'chrome': 220 if system == 'linux' and runtime == 'chrome':
221 # TODO(ngeoffray): We should install selenium on the buildbot. 221 # TODO(ngeoffray): We should install selenium on the buildbot.
222 runtime = 'drt' 222 runtime = 'drt'
223 elif ((runtime == 'ff' or runtime == 'chrome') and is_buildbot: 223 elif (runtime == 'ff' or runtime == 'chrome') and is_buildbot:
224 # Print out browser version numbers if we're running on the buildbot (where 224 # Print out browser version numbers if we're running on the buildbot (where
225 # we know the paths to these browser installations). 225 # we know the paths to these browser installations).
226 p = subprocess.Popen('%s --version' % GetPath(runtime), 226 p = subprocess.Popen('%s --version' % GetPath(runtime),
227 stdout=subprocess.PIPE, stderr=subprocess.PIPE, shell=True) 227 stdout=subprocess.PIPE, stderr=subprocess.PIPE, shell=True)
228 output, stderr = p.communicate() 228 output, stderr = p.communicate()
229 print 'Version of %s: %s' % (runtime, output) 229 print 'Version of %s: %s' % (runtime, output)
230 230
231 if compiler == 'dart2js': 231 if compiler == 'dart2js':
232 if option == 'checked': flags = flags + ['--host-checked'] 232 if option == 'checked': flags = flags + ['--host-checked']
233 233
(...skipping 98 matching lines...) Expand 10 before | Expand all | Expand 10 after
332 if status == 0 and option != 'checked' and runtime == 'd8': 332 if status == 0 and option != 'checked' and runtime == 'd8':
333 status = TestCompiler(compiler, runtime, mode, system, option, 333 status = TestCompiler(compiler, runtime, mode, system, option,
334 test_flags + ['--checked'], is_buildbot) 334 test_flags + ['--checked'], is_buildbot)
335 335
336 if runtime != 'd8': CleanUpTemporaryFiles(system, runtime) 336 if runtime != 'd8': CleanUpTemporaryFiles(system, runtime)
337 if status != 0: print '@@@STEP_FAILURE@@@' 337 if status != 0: print '@@@STEP_FAILURE@@@'
338 return status 338 return status
339 339
340 if __name__ == '__main__': 340 if __name__ == '__main__':
341 sys.exit(main()) 341 sys.exit(main())
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698