Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Side by Side Diff: src/ia32/macro-assembler-ia32.cc

Issue 10820014: Improve API calls that return empty handles. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/x64/macro-assembler-x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1906 matching lines...) Expand 10 before | Expand all | Expand 10 after
1917 bind(&leave_exit_frame); 1917 bind(&leave_exit_frame);
1918 1918
1919 // Check if the function scheduled an exception. 1919 // Check if the function scheduled an exception.
1920 ExternalReference scheduled_exception_address = 1920 ExternalReference scheduled_exception_address =
1921 ExternalReference::scheduled_exception_address(isolate()); 1921 ExternalReference::scheduled_exception_address(isolate());
1922 cmp(Operand::StaticVariable(scheduled_exception_address), 1922 cmp(Operand::StaticVariable(scheduled_exception_address),
1923 Immediate(isolate()->factory()->the_hole_value())); 1923 Immediate(isolate()->factory()->the_hole_value()));
1924 j(not_equal, &promote_scheduled_exception); 1924 j(not_equal, &promote_scheduled_exception);
1925 LeaveApiExitFrame(); 1925 LeaveApiExitFrame();
1926 ret(stack_space * kPointerSize); 1926 ret(stack_space * kPointerSize);
1927 bind(&promote_scheduled_exception);
1928 TailCallRuntime(Runtime::kPromoteScheduledException, 0, 1);
1929 1927
1930 bind(&empty_handle); 1928 bind(&empty_handle);
1931 // It was zero; the result is undefined. 1929 // It was zero; the result is undefined.
1932 mov(eax, isolate()->factory()->undefined_value()); 1930 mov(eax, isolate()->factory()->undefined_value());
1933 jmp(&prologue); 1931 jmp(&prologue);
1934 1932
1933 bind(&promote_scheduled_exception);
1934 TailCallRuntime(Runtime::kPromoteScheduledException, 0, 1);
1935
1935 // HandleScope limit has changed. Delete allocated extensions. 1936 // HandleScope limit has changed. Delete allocated extensions.
1936 ExternalReference delete_extensions = 1937 ExternalReference delete_extensions =
1937 ExternalReference::delete_handle_scope_extensions(isolate()); 1938 ExternalReference::delete_handle_scope_extensions(isolate());
1938 bind(&delete_allocated_handles); 1939 bind(&delete_allocated_handles);
1939 mov(Operand::StaticVariable(limit_address), edi); 1940 mov(Operand::StaticVariable(limit_address), edi);
1940 mov(edi, eax); 1941 mov(edi, eax);
1941 mov(Operand(esp, 0), Immediate(ExternalReference::isolate_address())); 1942 mov(Operand(esp, 0), Immediate(ExternalReference::isolate_address()));
1942 mov(eax, Immediate(delete_extensions)); 1943 mov(eax, Immediate(delete_extensions));
1943 call(eax); 1944 call(eax);
1944 mov(eax, edi); 1945 mov(eax, edi);
(...skipping 970 matching lines...) Expand 10 before | Expand all | Expand 10 after
2915 // Load the prototype from the map and loop if non-null. 2916 // Load the prototype from the map and loop if non-null.
2916 bind(&check_prototype); 2917 bind(&check_prototype);
2917 mov(ecx, FieldOperand(ebx, Map::kPrototypeOffset)); 2918 mov(ecx, FieldOperand(ebx, Map::kPrototypeOffset));
2918 cmp(ecx, isolate()->factory()->null_value()); 2919 cmp(ecx, isolate()->factory()->null_value());
2919 j(not_equal, &next); 2920 j(not_equal, &next);
2920 } 2921 }
2921 2922
2922 } } // namespace v8::internal 2923 } } // namespace v8::internal
2923 2924
2924 #endif // V8_TARGET_ARCH_IA32 2925 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « no previous file | src/x64/macro-assembler-x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698