Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10820007: Move all the layout tests that ran under browser_tests to run under content_browsertests. (Closed)

Created:
8 years, 5 months ago by jam
Modified:
8 years, 5 months ago
Reviewers:
scottmg
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, apatrick_chromium
Visibility:
Public.

Description

Move all the layout tests that ran under browser_tests to run under content_browsertests. To support the new tests, I added new methods to create new normal/incognito windows in content_browsertests. BUG=90448 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=148349

Patch Set 1 : #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : fix mac #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+210 lines, -332 lines) Patch
M ash/shell/content_client/shell_browser_main_parts.cc View 1 2 3 1 chunk +1 line, -1 line 1 comment Download
M chrome/browser_tests.isolate View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/chrome_tests.gypi View 4 chunks +0 lines, -11 lines 0 comments Download
M chrome/test/base/in_process_browser_test.h View 3 chunks +0 lines, -8 lines 0 comments Download
M chrome/test/base/in_process_browser_test.cc View 1 2 3 4 2 chunks +1 line, -7 lines 0 comments Download
D chrome/test/base/layout_test_http_server.h View 1 chunk +0 lines, -53 lines 0 comments Download
D chrome/test/base/layout_test_http_server.cc View 1 chunk +0 lines, -134 lines 0 comments Download
M chrome/test/base/ui_test_utils.h View 2 chunks +0 lines, -4 lines 0 comments Download
M chrome/test/base/ui_test_utils.cc View 2 chunks +0 lines, -17 lines 0 comments Download
M chrome/test/gpu/gpu_crash_browsertest.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/test/perf/dromaeo_benchmark_uitest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/in_process_webkit/indexed_db_layout_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/media_browsertest.cc View 2 chunks +7 lines, -11 lines 0 comments Download
M content/browser/plugin_browsertest.cc View 4 chunks +10 lines, -9 lines 0 comments Download
M content/browser/worker_host/test/worker_browsertest.cc View 12 chunks +48 lines, -41 lines 0 comments Download
M content/content_tests.gypi View 2 chunks +9 lines, -0 lines 0 comments Download
M content/public/test/browser_test_utils.h View 1 chunk +3 lines, -0 lines 0 comments Download
M content/shell/shell_browser_context.h View 2 chunks +2 lines, -1 line 0 comments Download
M content/shell/shell_browser_context.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M content/shell/shell_browser_main_parts.h View 1 chunk +4 lines, -0 lines 0 comments Download
M content/shell/shell_browser_main_parts.cc View 2 chunks +3 lines, -1 line 0 comments Download
M content/shell/shell_content_browser_client.h View 1 chunk +4 lines, -0 lines 0 comments Download
M content/shell/shell_content_browser_client.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M content/shell/shell_resource_dispatcher_host_delegate.h View 2 chunks +9 lines, -0 lines 0 comments Download
M content/shell/shell_resource_dispatcher_host_delegate.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M content/shell/shell_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/shell/shell_switches.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M content/test/browser_test_base.h View 1 2 3 4 2 chunks +16 lines, -0 lines 0 comments Download
M content/test/browser_test_base.cc View 1 2 3 4 2 chunks +10 lines, -0 lines 0 comments Download
M content/test/browser_test_utils.cc View 2 chunks +13 lines, -0 lines 0 comments Download
M content/test/content_browser_test.h View 2 chunks +9 lines, -1 line 0 comments Download
M content/test/content_browser_test.cc View 1 2 3 4 3 chunks +26 lines, -0 lines 0 comments Download
M content/test/layout_browsertest.h View 1 chunk +3 lines, -2 lines 0 comments Download
M content/test/layout_browsertest.cc View 3 chunks +8 lines, -11 lines 0 comments Download
A + content/test/layout_test_http_server.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + content/test/layout_test_http_server.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/views/examples/content_client/examples_browser_main_parts.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
jam
8 years, 5 months ago (2012-07-25 02:05:25 UTC) #1
scottmg
8 years, 5 months ago (2012-07-25 16:20:20 UTC) #2 
lgtm once mac and linux work

http://codereview.chromium.org/10820007/diff/3014/ash/shell/content_client/sh...
File ash/shell/content_client/shell_browser_main_parts.cc (right):

http://codereview.chromium.org/10820007/diff/3014/ash/shell/content_client/sh...
ash/shell/content_client/shell_browser_main_parts.cc:88:
browser_context_.reset(new content::ShellBrowserContext(false));
the "false" is kind of opaque, is it worth ShellBrowserContext having a Create
and CreateOffTheRecord too and changing the few places that create one?

Powered by Google App Engine
This is Rietveld 408576698