ash: Make sure swipe-to-snap gestures work correctly on maximized windows.

ash: Make sure swipe-to-snap gestures work correctly on maximized windows.

In case the window is already maximized/fullscreen, then restore the
window first before snapping.

BUG=138874
TEST=none

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=148336

[sky, 2012-07-25 04:28:53]

http://codereview.chromium.org/10820005/diff/1/ash/wm/system_gesture_event_fi...
File ash/wm/system_gesture_event_filter.cc (right):

http://codereview.chromium.org/10820005/diff/1/ash/wm/system_gesture_event_fi...
ash/wm/system_gesture_event_filter.cc:420: if (wm::IsWindowMaximized(target_) ||
Should we check if it has restore bounds instead of this? That way it handles
the case of being maximized along an axis, which isn't truly maximized.

[sadrul, 2012-07-25 05:37:54]

http://codereview.chromium.org/10820005/diff/1/ash/wm/system_gesture_event_fi...
File ash/wm/system_gesture_event_filter.cc (right):

http://codereview.chromium.org/10820005/diff/1/ash/wm/system_gesture_event_fi...
ash/wm/system_gesture_event_filter.cc:420: if (wm::IsWindowMaximized(target_) ||
On 2012/07/25 04:28:53, sky wrote:
> Should we check if it has restore bounds instead of this? That way it handles
> the case of being maximized along an axis, which isn't truly maximized.

It looks like for vertical/horizontal maximized windows, the window-state is
still NORMAL, so just setting the bounds in line 431 would be sufficient for the
snap to take effect? (whereas if the window-state is MAXIMIZED or FULLSCREEN, we
have to set it to NORMAL first for SetBounds to take immediate effect)

[sky, 2012-07-25 15:42:22]

ok, LGTM