Issue 10820003: Remove ui_resources_default_100_percent.rc and theme_resources_default_100_percent.rc

Issue 10820003: Remove ui_resources_default_100_percent.rc and theme_resources_default_100_percent.rc (Closed)

Created:
8 years, 5 months ago by benrg

Modified:
8 years, 5 months ago

Reviewers:
sail, Ben Goodger (Google)

CC:
chromium-reviews, sadrul, ben+watch_chromium.org, Ian Vollick, grt+watch_chromium.org, amit, jonathan.backer, apatrick_chromium, robertshield, oshima+watch_chromium.org, tfarina, piman+watch_chromium.org, oshima

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Remove ui_resources_default_100_percent.rc and theme_resources_default_100_percent.rc These files (included in chrome.dll on Windows) have the same contents as the corresponding .pak files. Aside from wasting space, this indirectly caused bug 137715 (the Windows resources take precedence over .pak file resources even when not at default_100_percent). Some day we may consider using Windows resources instead of paks (for all scales), but right now we don't need these RC files. BUG=137715, 137917 TEST=trybots, visual inspection Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148435

Patch Set 1 : rebase #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -32 lines)			Patch
M	ash/ash.gyp	View	2 chunks	+0 lines, -3 lines	0 comments	Download
M	chrome/app/theme/theme_resources.grd	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/chrome_dll.gypi	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	chrome/chrome_tests.gypi	View	7 chunks	+0 lines, -14 lines	0 comments	Download
M	chrome/test/gpu/test_support_gpu.gypi	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	chrome_frame/chrome_frame.gyp	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	ui/aura/aura.gyp	View	3 chunks	+0 lines, -3 lines	0 comments	Download
M	ui/compositor/compositor.gyp	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	ui/resources/ui_resources.grd	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	ui/ui_unittests.gypi	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	ui/views/views.gyp	View	2 chunks	+0 lines, -3 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/benrg@chromium.org/10820003/5002

8 years, 5 months ago (2012-07-25 21:07:45 UTC) #5

Change committed as 148435

Expand Messages | Collapse Messages