Upstream Android LongPressDetector

Upstream Android LongPressDetector

Include the LongPressDetectorTest as part of the
ContentShellTests.apk.

Produce a jar (ContentShellTests-debug.jar) so that
run_instrumentation_tests.py can use Proguard to enumerate the tests
by annotation.

BUG=136687
TEST=LongPressDetectorTest


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148636

[Yusuf, 2012-07-24 19:44:27]

This is rebased from https://chromiumcodereview.appspot.com/10690190/ and 
http://codereview.chromium.org/10802036/

submitted by @jknotten and @bulach before

[Yusuf, 2012-07-24 20:59:25]

@brettw for base and content
@yfriedman for content/public/android
@jochen for content/shell

[Ted C, 2012-07-24 21:01:28]

https://chromiumcodereview.appspot.com/10818039/diff/1/content/content_shell....
File content/content_shell.gypi (right):

https://chromiumcodereview.appspot.com/10818039/diff/1/content/content_shell....
content/content_shell.gypi:561: 'target_name': 'content_javatests',
any reason why this doesn't live within content_tests.gypi?

https://chromiumcodereview.appspot.com/10818039/diff/1/content/public/android...
File
content/public/android/java/src/org/chromium/content/browser/LongPressDetector.java
(right):

https://chromiumcodereview.appspot.com/10818039/diff/1/content/public/android...
content/public/android/java/src/org/chromium/content/browser/LongPressDetector.java:16:

remove extra line

https://chromiumcodereview.appspot.com/10818039/diff/1/content/shell/android/...
File content/shell/android/javatests/content_shell_test_apk.xml (right):

https://chromiumcodereview.appspot.com/10818039/diff/1/content/shell/android/...
content/shell/android/javatests/content_shell_test_apk.xml:69: be used to list
the tests by annotation. -->
align with 'We'

[Yusuf, 2012-07-24 22:37:56]

Yaron, can you take a look at my question about gyp targets in the comments when
you get a chance? Thanks.

https://chromiumcodereview.appspot.com/10818039/diff/1/content/content_shell....
File content/content_shell.gypi (right):

https://chromiumcodereview.appspot.com/10818039/diff/1/content/content_shell....
content/content_shell.gypi:561: 'target_name': 'content_javatests',
I think the reason was to keep this target and the content_shell_test_apk in the
same file. content_test.gypi seems to require defining a few variables in
common.gypi(like chromeos). 

Should I be moving content_javatests and content_shell_test_apk both or include
common.gypi in content_shell.gypi?

On 2012/07/24 21:01:28, Ted C wrote:
> any reason why this doesn't live within content_tests.gypi?

[Yaron, 2012-07-24 23:28:22]

https://chromiumcodereview.appspot.com/10818039/diff/1/content/content_shell....
File content/content_shell.gypi (right):

https://chromiumcodereview.appspot.com/10818039/diff/1/content/content_shell....
content/content_shell.gypi:561: 'target_name': 'content_javatests',
On 2012/07/24 22:37:56, yusufo1 wrote:
> I think the reason was to keep this target and the content_shell_test_apk in
the
> same file. content_test.gypi seems to require defining a few variables in
> common.gypi(like chromeos). 
> 
> Should I be moving content_javatests and content_shell_test_apk both or
include
> common.gypi in content_shell.gypi?
> 
> On 2012/07/24 21:01:28, Ted C wrote:
> > any reason why this doesn't live within content_tests.gypi?
> 

I tend to agree that this should be in content_tests.gypi. For that matter,
content_shell_test_apk should also move.

[jochen (gone - plz use gerrit), 2012-07-25 14:51:10]

content/shell LGTM with nits

http://codereview.chromium.org/10818039/diff/8001/content/shell/android/javat...
File content/shell/android/javatests/content_shell_test_apk.xml (right):

http://codereview.chromium.org/10818039/diff/8001/content/shell/android/javat...
content/shell/android/javatests/content_shell_test_apk.xml:68: <!-- We also want
a .jar as well as an .apk for so that proguard can
for = file?

http://codereview.chromium.org/10818039/diff/8001/content/shell/android/javat...
content/shell/android/javatests/content_shell_test_apk.xml:69: be used to list
the tests by annotation. -->
nit. indent two more spaces so "We" and "be" is alligned

[Yusuf, 2012-07-25 18:21:51]

@brettw friendly ping on taking a look at this one. Please let me know if I
should be adding someone else for review. Thanks a lot!

[brettw, 2012-07-26 17:17:12]

Owners lgtm with target rename. I didn't look at any java code.

http://codereview.chromium.org/10818039/diff/14001/base/base.gyp
File base/base.gyp (right):

http://codereview.chromium.org/10818039/diff/14001/base/base.gyp#newcode1003
base/base.gyp:1003: 'target_name': 'base_javatests',
This should probably be called "test_support" somehow if it's a library and not
a test suite you run, to match what we do on the C++ side. So maybe
"base_java_test_support"?

[Yaron, 2012-07-26 17:32:18]

lgtm

[commit-bot: I haz the power, 2012-07-26 17:36:33]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yusufo@chromium.org/10818039/15002

[commit-bot: I haz the power, 2012-07-26 22:39:07]

Change committed as 148636