Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(630)

Unified Diff: runtime/vm/intermediate_language_ia32.cc

Issue 10818032: Adjust location summaries to match expectations of new register allocator. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/intermediate_language.cc ('k') | runtime/vm/intermediate_language_x64.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/intermediate_language_ia32.cc
diff --git a/runtime/vm/intermediate_language_ia32.cc b/runtime/vm/intermediate_language_ia32.cc
index 8f2036bf1feaddebf4993ac48a32ead07ec5f2f1..2606359de4b902f85d78709b9ff2d0067b4df75d 100644
--- a/runtime/vm/intermediate_language_ia32.cc
+++ b/runtime/vm/intermediate_language_ia32.cc
@@ -168,6 +168,18 @@ LocationSummary* AssertAssignableComp::MakeLocationSummary() const {
}
+LocationSummary* AssertBooleanComp::MakeLocationSummary() const {
+ const intptr_t kNumInputs = 1;
+ const intptr_t kNumTemps = 0;
+ LocationSummary* locs = new LocationSummary(kNumInputs,
+ kNumTemps,
+ LocationSummary::kCall);
+ locs->set_in(0, Location::RegisterLocation(EAX));
+ locs->set_out(Location::RegisterLocation(EAX));
+ return locs;
+}
+
+
void AssertBooleanComp::EmitNativeCode(FlowGraphCompiler* compiler) {
Register obj = locs()->in(0).reg();
Register result = locs()->out().reg();
@@ -227,9 +239,9 @@ LocationSummary* EqualityCompareComp::MakeLocationSummary() const {
LocationSummary* locs = new LocationSummary(kNumInputs,
kNumTemps,
LocationSummary::kCall);
- locs->set_in(0, Location::RequiresRegister());
- locs->set_in(1, Location::RequiresRegister());
- locs->set_temp(0, Location::RequiresRegister());
+ locs->set_in(0, Location::RegisterLocation(ECX));
+ locs->set_in(1, Location::RegisterLocation(EDX));
+ locs->set_temp(0, Location::RegisterLocation(EBX));
locs->set_out(Location::RegisterLocation(EAX));
return locs;
}
@@ -237,8 +249,8 @@ LocationSummary* EqualityCompareComp::MakeLocationSummary() const {
LocationSummary* locs = new LocationSummary(kNumInputs,
kNumTemps,
LocationSummary::kCall);
- locs->set_in(0, Location::RequiresRegister());
- locs->set_in(1, Location::RequiresRegister());
+ locs->set_in(0, Location::RegisterLocation(ECX));
+ locs->set_in(1, Location::RegisterLocation(EDX));
locs->set_out(Location::RegisterLocation(EAX));
return locs;
}
@@ -1132,9 +1144,15 @@ void CreateArrayComp::EmitNativeCode(FlowGraphCompiler* compiler) {
LocationSummary*
AllocateObjectWithBoundsCheckComp::MakeLocationSummary() const {
- return LocationSummary::Make(2,
- Location::RequiresRegister(),
- LocationSummary::kCall);
+ const intptr_t kNumInputs = 2;
+ const intptr_t kNumTemps = 0;
+ LocationSummary* locs = new LocationSummary(kNumInputs,
+ kNumTemps,
+ LocationSummary::kCall);
+ locs->set_in(0, Location::RegisterLocation(EAX));
+ locs->set_in(1, Location::RegisterLocation(ECX));
+ locs->set_out(Location::RegisterLocation(EAX));
+ return locs;
}
@@ -1193,9 +1211,9 @@ LocationSummary* InstantiateTypeArgumentsComp::MakeLocationSummary() const {
LocationSummary* locs = new LocationSummary(kNumInputs,
kNumTemps,
LocationSummary::kCall);
- locs->set_in(0, Location::RequiresRegister());
- locs->set_temp(0, Location::RequiresRegister());
- locs->set_out(Location::SameAsFirstInput());
+ locs->set_in(0, Location::RegisterLocation(EAX));
+ locs->set_temp(0, Location::RegisterLocation(ECX));
+ locs->set_out(Location::RegisterLocation(EAX));
return locs;
}
@@ -1485,9 +1503,9 @@ LocationSummary* BinaryOpComp::MakeLocationSummary() const {
LocationSummary* summary =
new LocationSummary(kNumInputs, kNumTemps, LocationSummary::kCall);
summary->set_in(0, Location::RegisterLocation(EAX));
- summary->set_in(1, Location::RequiresRegister());
- summary->set_out(Location::SameAsFirstInput());
- summary->set_temp(0, Location::RequiresRegister());
+ summary->set_in(1, Location::RegisterLocation(ECX));
+ summary->set_temp(0, Location::RegisterLocation(EDX));
+ summary->set_out(Location::RegisterLocation(EAX));
return summary;
}
@@ -1518,10 +1536,10 @@ LocationSummary* BinaryOpComp::MakeLocationSummary() const {
LocationSummary* summary =
new LocationSummary(kNumInputs, kNumTemps, LocationSummary::kCall);
summary->set_in(0, Location::RegisterLocation(EAX));
- summary->set_in(1, Location::RequiresRegister());
- summary->set_out(Location::SameAsFirstInput());
- summary->set_temp(0, Location::RequiresRegister());
+ summary->set_in(1, Location::RegisterLocation(EDX));
+ summary->set_temp(0, Location::RegisterLocation(EBX));
summary->set_temp(1, Location::RegisterLocation(ECX));
+ summary->set_out(Location::RegisterLocation(EAX));
return summary;
} else {
const intptr_t kNumTemps = 1;
@@ -1897,9 +1915,9 @@ LocationSummary* NumberNegateComp::MakeLocationSummary() const {
LocationSummary* summary = new LocationSummary(kNumInputs,
kNumTemps,
LocationSummary::kCall);
- summary->set_in(0, Location::RequiresRegister());
- summary->set_out(Location::SameAsFirstInput());
- summary->set_temp(0, Location::RequiresRegister());
+ summary->set_in(0, Location::RegisterLocation(EAX));
+ summary->set_temp(0, Location::RegisterLocation(ECX));
+ summary->set_out(Location::RegisterLocation(EAX));
return summary;
}
@@ -2107,9 +2125,9 @@ LocationSummary* BranchInstr::MakeLocationSummary() const {
LocationSummary* locs = new LocationSummary(kNumInputs,
kNumTemps,
LocationSummary::kCall);
- locs->set_in(0, Location::RequiresRegister());
- locs->set_in(1, Location::RequiresRegister());
- locs->set_temp(0, Location::RequiresRegister());
+ locs->set_in(0, Location::RegisterLocation(EAX));
+ locs->set_in(1, Location::RegisterLocation(ECX));
+ locs->set_temp(0, Location::RegisterLocation(EDX));
return locs;
}
// Otherwise polymorphic dispatch.
« no previous file with comments | « runtime/vm/intermediate_language.cc ('k') | runtime/vm/intermediate_language_x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698