Chromium Code Reviews
Help | Chromium Project | Sign in
(1221)

Issue 10818031: Alternative GDrive promo for the File Manager (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 9 months ago by Vladislav Kaznacheev
Modified:
1 year, 9 months ago
Reviewers:
Dmitry Zvorygin
CC:
chromium-reviews_chromium.org, mihaip-chromium-reviews_chromium.org, nkostylev+watch_chromium.org, Aaron Boodman, rginda+watch_chromium.org, arv, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Alternative GDrive promo for the File Manager

BUG=138954
TEST=


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148388

Patch Set 1 #

Patch Set 2 : Rebase #

Total comments: 9

Patch Set 3 : Addressed comments #

Patch Set 4 : Some tweaks #

Unified diffs Side-by-side diffs Delta from patch set Stats (+140 lines, -13 lines) Lint Patch
M chrome/app/generated_resources.grd View 2 chunks +6 lines, -0 lines 0 comments ? errors Download
M chrome/browser/chromeos/extensions/file_browser_private_api.cc View 3 chunks +11 lines, -0 lines 0 comments 0 errors Download
M chrome/browser/chromeos/system/statistics_provider.cc View 3 chunks +10 lines, -0 lines 0 comments 0 errors Download
M chrome/browser/resources/file_manager/css/gdrive_welcome.css View 1 2 3 5 chunks +50 lines, -5 lines 0 comments ? errors Download
M chrome/browser/resources/file_manager/js/file_manager.js View 1 2 3 4 chunks +48 lines, -7 lines 0 comments ? errors Download
M chrome/browser/resources/file_manager/js/mock_chrome.js View 1 2 3 4 chunks +11 lines, -1 line 0 comments ? errors Download
M chrome/common/chrome_switches.h View 1 1 chunk +1 line, -0 lines 0 comments ? errors Download
M chrome/common/chrome_switches.cc View 1 1 chunk +3 lines, -0 lines 0 comments ? errors Download
Commit:

Messages

Total messages: 5
Vladislav Kaznacheev
Please review
1 year, 9 months ago #1
Dmitry Zvorygin
LGTM, just take a look at my notes. http://codereview.chromium.org/10818031/diff/3001/chrome/browser/chromeos/system/statistics_provider.cc File chrome/browser/chromeos/system/statistics_provider.cc (right): http://codereview.chromium.org/10818031/diff/3001/chrome/browser/chromeos/system/statistics_provider.cc#newcode215 chrome/browser/chromeos/system/statistics_provider.cc:215: if ...
1 year, 9 months ago #2
Vladislav Kaznacheev
https://chromiumcodereview.appspot.com/10818031/diff/3001/chrome/browser/chromeos/system/statistics_provider.cc File chrome/browser/chromeos/system/statistics_provider.cc (right): https://chromiumcodereview.appspot.com/10818031/diff/3001/chrome/browser/chromeos/system/statistics_provider.cc#newcode215 chrome/browser/chromeos/system/statistics_provider.cc:215: if (name == "CHROMEOS_RELEASE_BOARD") { The meaning in C++ ...
1 year, 9 months ago #3
I haz the power (commit-bot)
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kaznacheev@chromium.org/10818031/7002
1 year, 9 months ago #4
I haz the power (commit-bot)
1 year, 9 months ago #5
Change committed as 148388
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6