Implements iOS device util methods.

base/ios/device_util_unittest.mm

+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#import <Foundation/Foundation.h>
+
+#include "base/ios/device_util.h"
+#include "base/sys_string_conversions.h"
+#include "testing/gtest/include/gtest/gtest.h"
+#include "testing/gtest_mac.h"
+#include "testing/platform_test.h"
+
+namespace {
+
+typedef PlatformTest DeviceUtilTest;
+
+TEST_F(DeviceUtilTest, Platform) {
+  // The result here depends on what it is run on, so there isn't
+  // really a way to unittest it.  Just run the api to make sure it
+  // doesn't choke and returns a string with something in it.
+  NSString* platformStr = base::SysUTF8ToNSString(

[Mark Mentovai, 2012/07/25 14:00:23]

platform_string

[Mark Mentovai, 2012/07/25 14:00:23]

Why is this an NSString* with a conversion instead of a std::string? You’re not
using any special NSString* features. You’re just checking the string’s length,
which std::string is more than capable of.

[Chen Yu, 2012/07/27 16:28:17]

Done.

+      ios::device_util::GetPlatform());
+  GTEST_ASSERT_GT([platformStr length], 0U);
+}
+
+TEST_F(DeviceUtilTest, IsRunningOnHighRamDevice) {
+  // The true/false here depends on what it is run on, so there isn't
+  // really a way to unittest it.  Just run the api to make sure it
+  // doesn't choke.
+  (void)ios::device_util::IsRunningOnHighRamDevice();

[Mark Mentovai, 2012/07/25 14:00:23]

Get rid of that silly cast. Nobody’s marked this function with the
warn_unused_result attribute.

[Chen Yu, 2012/07/27 16:28:17]

Done.

+}
+
+TEST_F(DeviceUtilTest, DeviceIdentifier) {
+  NSString* default_id =

[Mark Mentovai, 2012/07/25 14:00:23]

Why NSString* and a conversion? You can test std::string objects for equality.

+      base::SysUTF8ToNSString(ios::device_util::GetDeviceIdentifier(NULL));
+  NSString* other_id =
+      base::SysUTF8ToNSString(ios::device_util::GetDeviceIdentifier("ForTest"));
+  EXPECT_NSNE(default_id, other_id);
+
+  NSUserDefaults* defaults = [NSUserDefaults standardUserDefaults];
+  [defaults removeObjectForKey:@"ChromiumClientID"];

[Mark Mentovai, 2012/07/25 14:00:23]

Will this trash the client ID used by the real app? That wouldn’t be great.

[stuartmorgan, 2012/07/30 14:28:54]

Nope, defaults are per-app.

+  [defaults synchronize];
+
+  NSString* new_default_id =
+      base::SysUTF8ToNSString(ios::device_util::GetDeviceIdentifier(NULL));
+  EXPECT_NSNE(default_id, new_default_id);
+}
+
+}  // anonymous namespace

[Mark Mentovai, 2012/07/25 14:00:23]

End unnamed namespaces with

}  // namespace

not this.

[Chen Yu, 2012/07/27 16:28:17]

Done.