Implements iOS device util methods.

base/ios/device_util.h

+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef BASE_IOS_DEVICE_UTIL_H_
+#define BASE_IOS_DEVICE_UTIL_H_
+
+#include <string>
+
+namespace ios {
+namespace device_util {

[stuartmorgan, 2012/07/24 13:38:49]

Add a blank line after this.

[Chen Yu, 2012/07/24 14:34:20]

Done.

+// This methods returns the hardware version of the device the app is running
+// on.
+// Possible (known) values are:

[stuartmorgan, 2012/07/24 13:38:49]

s/are/include/ since we know this list isn't exhaustive

[Chen Yu, 2012/07/24 14:34:20]

Done.

+// iPhone1,1 -> iPhone 1G
+// iPhone1,2 -> iPhone 3G
+// iPhone2,1 -> iPhone 3GS
+// iPhone3,1 -> iPhone 4/AT&T
+// iPhone3,2 -> iPhone 4/Other Carrier?
+// iPhone3,3 -> iPhone 4/Other Carrier?
+// iPhone4,1 -> ??iPhone 5
+//
+// iPod1,1   -> iPod touch 1G
+// iPod2,1   -> iPod touch 2G
+// iPod2,2   -> ??iPod touch 2.5G
+// iPod3,1   -> iPod touch 3G
+// iPod4,1   -> iPod touch 4G
+// iPod5,1   -> ??iPod touch 5G
+//
+// iPad1,1   -> iPad 1G, WiFi
+// iPad1,?   -> iPad 1G, 3G <- needs 3G owner to test
+// iPad2,1   -> iPad 2G (iProd 2,1)
+//
+// AppleTV2,1 -> AppleTV 2
+//
+// (The returned string is the string returned by sysctlbyname() with name
+// "hw.machine".)
+std::string platform();

[stuartmorgan, 2012/07/24 13:38:49]

All of these methods need to be converted to FunctionStyleNaming, not
objCMethodStyleNaming.

[Chen Yu, 2012/07/24 14:34:20]

Done.

+
+// Returns if the application is running on a high-ram device. (>=250M).

[stuartmorgan, 2012/07/24 13:38:49]

s/if/true if/

[Chen Yu, 2012/07/24 14:34:20]

Done.

+bool isRunningOnHighRamDevice();
+
+// Some features are restricted on supported single core devices. "iPhone2,1" is
+// an iPhone 3GS, "iPad1,1" is an iPad 1, and "iPhone3,1" is an iPhone 4.

[stuartmorgan, 2012/07/24 13:38:49]

Replace this whole comment with "Returns true if the device has only one core".
You can move the second sentence into the implementation.

[Chen Yu, 2012/07/24 14:34:20]

Done.

+bool isSingleCoreDevice();
+
+// Returns the first mac address.

[stuartmorgan, 2012/07/24 13:38:49]

MAC address

[Chen Yu, 2012/07/24 14:34:20]

Done.

+std::string macAddress(std::string ifName);
+
+// Returns a random UUID.
+std::string randomId();
+
+// Returns an identifier for the device, using the given |salt|. A global
+// identifier is generated the first time this method is called, and the salt
+// is used to be able to generate distinct identifiers for the same device. If
+// |salt| is NULL, a default value is used. Unless you are using this value for
+// something that should be anonymous, you should probably pass NULL.
+std::string deviceIdentifier(const char* const salt);
+
+}  // namespace device_util
+}  // namespace ios
+
+#endif  // BASE_IOS_DEVICE_UTIL_H_