Setuid sandbox client class readability meta-CL

Correct style issues in Linux sandbox code.

NOTRY=true

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=152123

[jln (very slow on Chromium), 2012-07-24 00:00:06]

Dhyanesh, here is the CL.

(Please note that anything here is public).

[dhyanesh, 2012-08-06 10:27:52]

https://chromiumcodereview.appspot.com/10818015/diff/3001/sandbox/linux/suid/...
File sandbox/linux/suid/client/setuid_sandbox_client.cc (right):

https://chromiumcodereview.appspot.com/10818015/diff/3001/sandbox/linux/suid/...
sandbox/linux/suid/client/setuid_sandbox_client.cc:31: std::string*
CreateSavedVariableName(const char* envvar) {
Use underscores between words in variable names. 

http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml#Variable_Names

https://chromiumcodereview.appspot.com/10818015/diff/3001/sandbox/linux/suid/...
sandbox/linux/suid/client/setuid_sandbox_client.cc:47: const char* const env_var
= kSUIDUnsafeEnvironmentVariables[i];
Look at the section of "where to put const" in this link:

http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Use_of...

The decision is to use const only at the start if it is applicable, otherwise
leave it out.

https://chromiumcodereview.appspot.com/10818015/diff/3001/sandbox/linux/suid/...
sandbox/linux/suid/client/setuid_sandbox_client.cc:116: int fd =
GetIPCDescriptor(env_);
Use descriptive variable names. Look at this section:

http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Use_of...

[jln (very slow on Chromium), 2012-08-06 18:05:49]

https://chromiumcodereview.appspot.com/10818015/diff/3001/sandbox/linux/suid/...
File sandbox/linux/suid/client/setuid_sandbox_client.cc (right):

https://chromiumcodereview.appspot.com/10818015/diff/3001/sandbox/linux/suid/...
sandbox/linux/suid/client/setuid_sandbox_client.cc:31: std::string*
CreateSavedVariableName(const char* envvar) {
On 2012/08/06 10:27:52, dhyanesh wrote:
> Use underscores between words in variable names. 
> 
> http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml#Variable_Names

Done.

https://chromiumcodereview.appspot.com/10818015/diff/3001/sandbox/linux/suid/...
sandbox/linux/suid/client/setuid_sandbox_client.cc:47: const char* const env_var
= kSUIDUnsafeEnvironmentVariables[i];
On 2012/08/06 10:27:52, dhyanesh wrote:
> Look at the section of "where to put const" in this link:
> 
>
http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Use_of...
> 
> The decision is to use const only at the start if it is applicable, otherwise
> leave it out.

Done.

https://chromiumcodereview.appspot.com/10818015/diff/3001/sandbox/linux/suid/...
sandbox/linux/suid/client/setuid_sandbox_client.cc:116: int fd =
GetIPCDescriptor(env_);
On 2012/08/06 10:27:52, dhyanesh wrote:
> Use descriptive variable names. Look at this section:
> 
>
http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Use_of...

Done.

[dhyanesh, 2012-08-17 10:23:13]

lgtm

[Markus (顧孟勤), 2012-08-17 17:36:22]

lgtm

Looks fine. Sorry, I hadn't realized you still needed my review otherwise I
would have done it earlier.

[commit-bot: I haz the power, 2012-08-17 18:42:09]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jln@chromium.org/10818015/9003

[commit-bot: I haz the power, 2012-08-17 18:43:45]

Change committed as 152123