Issue 10818003: Interpret negative hexadecimal literals as NaN.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10818003: Interpret negative hexadecimal literals as NaN. (Closed)

Created:
8 years, 5 months ago by Yang

Modified:
8 years, 5 months ago

Reviewers:
rossberg

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Interpret negative hexadecimal literals as NaN. R=rossberg@chromium.org BUG=v8:2240 TEST=str-to-num.js Committed: https://code.google.com/p/v8/source/detail?r=12169

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : enum instead of bools #

Total comments: 1

Patch Set 4 : addressed commented issues #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -12 lines)			Patch
	M	src/conversions-inl.h	View	1 2 3	5 chunks	+17 lines, -10 lines	0 comments	Download
	M	test/mjsunit/str-to-num.js	View		3 chunks	+7 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

rossberg

I don't think this fix is correct. AFAICS, it would allow strings like "000+1" to ...

8 years, 5 months ago (2012-07-23 09:39:23 UTC) #2

rossberg

8 years, 5 months ago (2012-07-23 09:59:20 UTC) #3

LGTM with comment.

https://chromiumcodereview.appspot.com/10818003/diff/5001/src/conversions-inl.h
File src/conversions-inl.h (right):

https://chromiumcodereview.appspot.com/10818003/diff/5001/src/conversions-inl...
src/conversions-inl.h:465: EXPLICIT_POSITIVE
For symmetry, I'd call this POSITIVE, and the other NONE.

Expand Messages | Collapse Messages