Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 10817031: mac: Move cursor images from the bundle into the resource pak file. (Closed)

Created:
8 years, 5 months ago by Nico
Modified:
8 years, 5 months ago
Reviewers:
tony, Avi (use Gerrit)
CC:
chromium-reviews, darin-cc_chromium.org
Visibility:
Public.

Description

mac: Load cursor images from resource pak file instead of from the bundle. Depends on https://bugs.webkit.org/show_bug.cgi?id=92148 Also, while I'm here, don't include the webkit .cur files on platforms other than windows. BUG=137588 TEST=Cursors show up fine in component builds. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148290

Patch Set 1 #

Total comments: 4

Patch Set 2 : tony #

Patch Set 3 : tony #

Patch Set 4 : tony #

Patch Set 5 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -53 lines) Patch
M webkit/glue/webcursor_mac.mm View 1 7 chunks +34 lines, -35 lines 0 comments Download
M webkit/glue/webkit_resources.grd View 1 2 3 4 2 chunks +21 lines, -18 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
Nico
https://chromiumcodereview.appspot.com/10817031/diff/1/webkit/glue/webkit_resources.grd File webkit/glue/webkit_resources.grd (right): https://chromiumcodereview.appspot.com/10817031/diff/1/webkit/glue/webkit_resources.grd#newcode58 webkit/glue/webkit_resources.grd:58: <include name="IDR_ALIAS_CURSOR" file="../../third_party/WebKit/Source/WebCore/Resources/aliasCursor.png" type="BINDATA" /> Once this is in, ...
8 years, 5 months ago (2012-07-24 18:50:21 UTC) #1
Avi (use Gerrit)
lgtm Can we kill GetCachedImageWithName entirely? https://chromiumcodereview.appspot.com/10817031/diff/1/webkit/glue/webkit_resources.grd File webkit/glue/webkit_resources.grd (right): https://chromiumcodereview.appspot.com/10817031/diff/1/webkit/glue/webkit_resources.grd#newcode58 webkit/glue/webkit_resources.grd:58: <include name="IDR_ALIAS_CURSOR" file="../../third_party/WebKit/Source/WebCore/Resources/aliasCursor.png" ...
8 years, 5 months ago (2012-07-24 18:53:17 UTC) #2
Nico
On Tue, Jul 24, 2012 at 11:53 AM, <avi@chromium.org> wrote: > lgtm > > Can ...
8 years, 5 months ago (2012-07-24 18:55:24 UTC) #3
tony
https://chromiumcodereview.appspot.com/10817031/diff/1/webkit/glue/webkit_resources.grd File webkit/glue/webkit_resources.grd (right): https://chromiumcodereview.appspot.com/10817031/diff/1/webkit/glue/webkit_resources.grd#newcode59 webkit/glue/webkit_resources.grd:59: <include name="IDR_CELL_CURSOR" file="../../third_party/WebKit/Source/WebCore/Resources/cellCursor.png" type="BINDATA" /> I don't think we ...
8 years, 5 months ago (2012-07-24 19:03:22 UTC) #4
Nico
Thanks! https://chromiumcodereview.appspot.com/10817031/diff/1/webkit/glue/webkit_resources.grd File webkit/glue/webkit_resources.grd (right): https://chromiumcodereview.appspot.com/10817031/diff/1/webkit/glue/webkit_resources.grd#newcode59 webkit/glue/webkit_resources.grd:59: <include name="IDR_CELL_CURSOR" file="../../third_party/WebKit/Source/WebCore/Resources/cellCursor.png" type="BINDATA" /> On 2012/07/24 19:03:22, ...
8 years, 5 months ago (2012-07-24 19:15:20 UTC) #5
tony
On 2012/07/24 19:15:20, Nico wrote: > I'm not sure it helps a ton though, because ...
8 years, 5 months ago (2012-07-24 19:16:50 UTC) #6
Nico
Addressed the downstream comments in this CL too. I'll wait with landing until https://bugs.webkit.org/show_bug.cgi?id=92148 is ...
8 years, 5 months ago (2012-07-24 19:18:07 UTC) #7
tony
LGTM
8 years, 5 months ago (2012-07-24 19:20:15 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/10817031/3002
8 years, 5 months ago (2012-07-25 02:40:58 UTC) #9
commit-bot: I haz the power
Failed to apply patch for webkit/glue/webkit_resources.grd: While running patch -p1 --forward --force; patching file webkit/glue/webkit_resources.grd ...
8 years, 5 months ago (2012-07-25 02:41:00 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/10817031/15001
8 years, 5 months ago (2012-07-25 02:47:57 UTC) #11
commit-bot: I haz the power
8 years, 5 months ago (2012-07-25 03:44:16 UTC) #12
Change committed as 148290

Powered by Google App Engine
This is Rietveld 408576698