Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issue 10817025: Fix failed cases ImageTest.* of ui unittests for Android (Closed)

Created:
8 years, 5 months ago by yongsheng
Modified:
8 years, 5 months ago
Reviewers:
Robert Sesek, Yaron, nilesh
CC:
chromium-reviews
Visibility:
Public.

Description

Fix failed cases ImageTest.* for Android For Android, it doesn't use views but use skia natively. BUG= TEST=run_tests.py -s ui_unittests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148287

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -9 lines) Patch
M build/android/gtest_filter/ui_unittests_disabled View 1 chunk +0 lines, -8 lines 0 comments Download
M ui/gfx/image/image_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
yongsheng
Owners, please help review it. thanks.
8 years, 5 months ago (2012-07-24 07:11:08 UTC) #1
Robert Sesek
LGTM
8 years, 5 months ago (2012-07-24 14:47:45 UTC) #2
Yaron
lgtm
8 years, 5 months ago (2012-07-24 14:52:19 UTC) #3
yongsheng
On 2012/07/24 14:52:19, Yaron wrote: > lgtm rsesek and Yaron, thanks for your review.
8 years, 5 months ago (2012-07-25 01:32:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yongsheng.zhu@intel.com/10817025/1
8 years, 5 months ago (2012-07-25 01:37:34 UTC) #5
commit-bot: I haz the power
8 years, 5 months ago (2012-07-25 03:01:09 UTC) #6
Change committed as 148287

Powered by Google App Engine
This is Rietveld 408576698