[Sync] Pass the correct set of enabled types to the sync notifier

[Sync] Pass the correct set of enabled types to the sync notifier

This fixes a bug where only the newly-configured types were being
passed to the sync notifier to enable.  In the common case, there is
an empty configuration cycle, which effectively causes notifications
to turn off.

For now, read the set of enabled types from the registrar and use
that.

Add unit test expectations to catch the bug above.

Move updating of the notification bridge's data types to the sync
thread.  Also clean up its unit tests a bit.

BUG=138595
TEST=


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148188

[akalin, 2012-07-24 03:27:54]

+zea for review

+dcheng, +rlarocque FYI

[akalin, 2012-07-24 17:33:51]

On 2012/07/24 03:27:54, akalin wrote:
> +zea for review
> 
> +dcheng, +rlarocque FYI

Ping!  Would like to get this in soon.

[Nicolas Zea, 2012-07-24 18:09:31]

LGTM

http://codereview.chromium.org/10817023/diff/1/chrome/browser/sync/glue/sync_...
File chrome/browser/sync/glue/sync_backend_host_unittest.cc (right):

http://codereview.chromium.org/10817023/diff/1/chrome/browser/sync/glue/sync_...
chrome/browser/sync/glue/sync_backend_host_unittest.cc:249:
syncer::ModelTypeSetToString(fake_manager_->GetAndResetEnabledTypes()),
.equals instead of string matching?

http://codereview.chromium.org/10817023/diff/1/chrome/browser/sync/test_profi...
File chrome/browser/sync/test_profile_sync_service.cc (right):

http://codereview.chromium.org/10817023/diff/1/chrome/browser/sync/test_profi...
chrome/browser/sync/test_profile_sync_service.cc:90: if (fail_initial_download_)
{
nit: remove curly brace

[akalin, 2012-07-24 18:59:39]

committing

http://codereview.chromium.org/10817023/diff/1/chrome/browser/sync/glue/sync_...
File chrome/browser/sync/glue/sync_backend_host_unittest.cc (right):

http://codereview.chromium.org/10817023/diff/1/chrome/browser/sync/glue/sync_...
chrome/browser/sync/glue/sync_backend_host_unittest.cc:249:
syncer::ModelTypeSetToString(fake_manager_->GetAndResetEnabledTypes()),
On 2012/07/24 18:09:31, nzea wrote:
> .equals instead of string matching?

oops, done.

http://codereview.chromium.org/10817023/diff/1/chrome/browser/sync/test_profi...
File chrome/browser/sync/test_profile_sync_service.cc (right):

http://codereview.chromium.org/10817023/diff/1/chrome/browser/sync/test_profi...
chrome/browser/sync/test_profile_sync_service.cc:90: if (fail_initial_download_)
{
On 2012/07/24 18:09:31, nzea wrote:
> nit: remove curly brace

Done.

[commit-bot: I haz the power, 2012-07-24 18:59:57]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/akalin@chromium.org/10817023/6002

[commit-bot: I haz the power, 2012-07-24 20:39:48]

Change committed as 148188