Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 10817021: Revert 147988 - Upgrade AlignedMemory to support dynamic allocations. (Closed)

Created:
8 years, 5 months ago by acolwell GONE FROM CHROMIUM
Modified:
8 years, 5 months ago
Reviewers:
DaleCurtis
CC:
chromium-reviews, erikwright (departed), Aaron Boodman, mihaip-chromium-reviews_chromium.org, gavinp+memory_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

Revert 147988 - Upgrade AlignedMemory to support dynamic allocations. Adds two new methods: AlignedAlloc and AlignedFree for creating and destroying dynamic aligned allocations respectively. Also adds a helper class, ScopedPtrAlignedFree, for use with scoped_ptr_malloc. AlignedAlloc uses posix_memalign for OS X (now that we're targeting 10.6), Linux and _aligned_alloc() on Windows. Android and NaCl use memalign() since they do not expose posix_memalign() and memalign() is safe to use with free() on those platforms. Also hacks around a bug in Visual C++ where __alignof will sometimes return zero: http://connect.microsoft.com/VisualStudio/feedback/details/682695/c-alignof-fails-to-properly-evalute-alignment-of-dependent-types BUG=none TEST=base_unittests + new test, trybots. Review URL: https://chromiumcodereview.appspot.com/10796020 TBR=dalecurtis@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=148016

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -131 lines) Patch
M base/base.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M base/compiler_specific.h View 1 chunk +2 lines, -4 lines 0 comments Download
M base/memory/aligned_memory.h View 3 chunks +7 lines, -45 lines 0 comments Download
D base/memory/aligned_memory.cc View 1 chunk +0 lines, -47 lines 0 comments Download
M base/memory/aligned_memory_unittest.cc View 1 chunk +0 lines, -29 lines 0 comments Download
M chrome/browser/history/android/android_urls_sql_handler.cc View 1 chunk +0 lines, -1 line 0 comments Download
MM chrome/browser/ui/find_bar/find_bar_controller.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/extensions/permissions/permissions_info.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
acolwell GONE FROM CHROMIUM
8 years, 5 months ago (2012-07-24 01:12:13 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698