Issue 10817018: gdata: First cut at implementing a debug console for Drive support

Issue 10817018: gdata: First cut at implementing a debug console for Drive support (Closed)

Created:
8 years, 5 months ago by satorux1

Modified:
8 years, 5 months ago

Reviewers:
James Hawkins

CC:
chromium-reviews, arv (Not doing code reviews), stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, oshima+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

gdata: First cut at implementing a debug console for Drive support Drive support for Chrome OS is complex enough for us to need a debug console ala chrome:net-internals. This will particularly be useful for diagnosing issues on a device not in the developer mode. BUG=135328 TEST=chrome:drive-internals showed something Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=148221

Patch Set 1 #

Patch Set 2 : polish #

Total comments: 2

Patch Set 3 : address comments #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+72 lines, -1 line)			Patch
M	chrome/browser/browser_resources.grd	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/resources/chromeos/OWNERS	View		1 chunk	+1 line, -0 lines	0 comments	Download
A	chrome/browser/resources/chromeos/drive_internals.html	View	1	1 chunk	+11 lines, -0 lines	0 comments	Download
A +	chrome/browser/resources/chromeos/drive_internals.js	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc	View		2 chunks	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/webui/chromeos/OWNERS	View		1 chunk	+1 line, -0 lines	0 comments	Download
A	chrome/browser/ui/webui/chromeos/drive_internals_ui.h	View	1 2	1 chunk	+23 lines, -0 lines	0 comments	Download
A	chrome/browser/ui/webui/chromeos/drive_internals_ui.cc	View	1	1 chunk	+26 lines, -0 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/common/url_constants.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/common/url_constants.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

James Hawkins

LGTM with nit. https://chromiumcodereview.appspot.com/10817018/diff/3001/chrome/browser/ui/webui/chromeos/drive_internals_ui.h File chrome/browser/ui/webui/chromeos/drive_internals_ui.h (right): https://chromiumcodereview.appspot.com/10817018/diff/3001/chrome/browser/ui/webui/chromeos/drive_internals_ui.h#newcode11 chrome/browser/ui/webui/chromeos/drive_internals_ui.h:11: class DriveInternalsUI : public content::WebUIController { ...

8 years, 5 months ago (2012-07-24 19:45:27 UTC) #3

satorux1

8 years, 5 months ago (2012-07-24 19:52:45 UTC) #4

https://chromiumcodereview.appspot.com/10817018/diff/3001/chrome/browser/ui/w...
File chrome/browser/ui/webui/chromeos/drive_internals_ui.h (right):

https://chromiumcodereview.appspot.com/10817018/diff/3001/chrome/browser/ui/w...
chrome/browser/ui/webui/chromeos/drive_internals_ui.h:11: class DriveInternalsUI
: public content::WebUIController {
On 2012/07/24 19:45:27, James Hawkins wrote:
> nit: Document class.

Good catch. Added.

Expand Messages | Collapse Messages