Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 10817013: Move ChromeAsyncSocket to jingle/glue (Closed)

Created:
8 years, 5 months ago by Sergey Ulanov
Modified:
8 years, 5 months ago
Reviewers:
akalin
CC:
chromium-reviews
Visibility:
Public.

Description

Move ChromeAsyncSocket to jingle/glue ChromeAsyncSocket will be reused by chromoting for XMPP connections, moving it to jingle/glue. BUG=137140 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148028

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Patch Set 7 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -3398 lines) Patch
A + jingle/glue/chrome_async_socket.h View 1 2 3 4 5 3 chunks +6 lines, -6 lines 0 comments Download
A + jingle/glue/chrome_async_socket.cc View 1 2 3 4 5 6 4 chunks +5 lines, -5 lines 0 comments Download
A + jingle/glue/chrome_async_socket_unittest.cc View 1 2 3 4 5 4 chunks +7 lines, -7 lines 0 comments Download
A + jingle/glue/fake_ssl_client_socket.h View 1 3 chunks +5 lines, -5 lines 0 comments Download
A + jingle/glue/fake_ssl_client_socket.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
A + jingle/glue/fake_ssl_client_socket_unittest.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
A + jingle/glue/proxy_resolving_client_socket.h View 1 3 chunks +5 lines, -5 lines 0 comments Download
A + jingle/glue/proxy_resolving_client_socket.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
A + jingle/glue/proxy_resolving_client_socket_unittest.cc View 1 2 3 4 3 chunks +3 lines, -3 lines 0 comments Download
A + jingle/glue/resolving_client_socket_factory.h View 1 3 chunks +6 lines, -6 lines 0 comments Download
A + jingle/glue/xmpp_client_socket_factory.h View 1 3 chunks +7 lines, -7 lines 0 comments Download
A + jingle/glue/xmpp_client_socket_factory.cc View 1 2 chunks +5 lines, -5 lines 0 comments Download
M jingle/jingle.gyp View 1 2 5 chunks +14 lines, -14 lines 0 comments Download
D jingle/notifier/base/chrome_async_socket.h View 2 1 chunk +0 lines, -213 lines 0 comments Download
D jingle/notifier/base/chrome_async_socket.cc View 2 1 chunk +0 lines, -450 lines 0 comments Download
D jingle/notifier/base/chrome_async_socket_unittest.cc View 2 1 chunk +0 lines, -1079 lines 0 comments Download
D jingle/notifier/base/fake_ssl_client_socket.h View 1 1 chunk +0 lines, -114 lines 0 comments Download
D jingle/notifier/base/fake_ssl_client_socket.cc View 1 1 chunk +0 lines, -353 lines 0 comments Download
D jingle/notifier/base/fake_ssl_client_socket_unittest.cc View 1 1 chunk +0 lines, -348 lines 0 comments Download
D jingle/notifier/base/proxy_resolving_client_socket.h View 1 1 chunk +0 lines, -106 lines 0 comments Download
D jingle/notifier/base/proxy_resolving_client_socket.cc View 1 1 chunk +0 lines, -392 lines 0 comments Download
D jingle/notifier/base/proxy_resolving_client_socket_unittest.cc View 1 2 3 4 1 chunk +0 lines, -117 lines 0 comments Download
D jingle/notifier/base/resolving_client_socket_factory.h View 1 1 chunk +0 lines, -36 lines 0 comments Download
D jingle/notifier/base/xmpp_client_socket_factory.h View 1 1 chunk +0 lines, -56 lines 0 comments Download
D jingle/notifier/base/xmpp_client_socket_factory.cc View 1 1 chunk +0 lines, -56 lines 0 comments Download
M jingle/notifier/base/xmpp_connection.cc View 1 2 2 chunks +6 lines, -6 lines 0 comments Download
M sync/sync.gyp View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
Sergey Ulanov
8 years, 5 months ago (2012-07-23 19:05:11 UTC) #1
akalin
On 2012/07/23 19:05:11, sergeyu wrote: LGTM hooray!
8 years, 5 months ago (2012-07-23 19:08:40 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/10817013/1
8 years, 5 months ago (2012-07-23 19:48:40 UTC) #3
commit-bot: I haz the power
Try job failure for 10817013-1 (retry) on mac_rel for step "compile" (clobber build). It's a ...
8 years, 5 months ago (2012-07-23 20:02:33 UTC) #4
Sergey Ulanov
Can you please take another look? Now I moved ResolvingClientSocketFactory and its implementations. ChromeAsyncSocket depends ...
8 years, 5 months ago (2012-07-23 20:46:00 UTC) #5
akalin
LGTM but do a pass over the DEPS files and clean it up a bit ...
8 years, 5 months ago (2012-07-23 23:00:51 UTC) #6
Sergey Ulanov
On 2012/07/23 23:00:51, akalin wrote: > LGTM > > but do a pass over the ...
8 years, 5 months ago (2012-07-23 23:20:14 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/10817013/13026
8 years, 5 months ago (2012-07-23 23:23:13 UTC) #8
commit-bot: I haz the power
Try job failure for 10817013-13026 (retry) on linux_rel for step "check_deps". It's a second try, ...
8 years, 5 months ago (2012-07-24 00:15:53 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/10817013/14
8 years, 5 months ago (2012-07-24 00:24:20 UTC) #10
commit-bot: I haz the power
8 years, 5 months ago (2012-07-24 01:54:43 UTC) #11
Change committed as 148028

Powered by Google App Engine
This is Rietveld 408576698