Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8171)

Unified Diff: chromeos/dbus/cryptohome_client.cc

Issue 10817007: Remove chromeos::CryptohomeLibrary::IsMounted and convert (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromeos/dbus/cryptohome_client.cc
diff --git a/chromeos/dbus/cryptohome_client.cc b/chromeos/dbus/cryptohome_client.cc
index 10855ca82a04754a0a84f3f361484af4e3803f81..55c2854fb0d4f8ef0ab5fa7555de0070bdb4afd6 100644
--- a/chromeos/dbus/cryptohome_client.cc
+++ b/chromeos/dbus/cryptohome_client.cc
@@ -53,9 +53,9 @@ class CryptohomeClientImpl : public CryptohomeClient {
}
// CryptohomeClient override.
- virtual bool IsMounted(bool* is_mounted) OVERRIDE {
+ virtual void IsMounted(const BoolMethodCallback& callback) {
INITIALIZE_METHOD_CALL(method_call, cryptohome::kCryptohomeIsMounted);
- return CallBoolMethodAndBlock(&method_call, is_mounted);
+ CallBoolMethod(&method_call, callback);
}
// CryptohomeClient override.
@@ -153,21 +153,13 @@ class CryptohomeClientImpl : public CryptohomeClient {
// CryptohomeClient override.
virtual void TpmIsReady(const BoolMethodCallback& callback) OVERRIDE {
INITIALIZE_METHOD_CALL(method_call, cryptohome::kCryptohomeTpmIsReady);
- proxy_->CallMethod(&method_call, dbus::ObjectProxy::TIMEOUT_USE_DEFAULT,
- base::Bind(
- &CryptohomeClientImpl::OnBoolMethod,
- weak_ptr_factory_.GetWeakPtr(),
- callback));
+ CallBoolMethod(&method_call, callback);
}
// CryptohomeClient override.
virtual void TpmIsEnabled(const BoolMethodCallback& callback) OVERRIDE {
INITIALIZE_METHOD_CALL(method_call, cryptohome::kCryptohomeTpmIsEnabled);
- proxy_->CallMethod(&method_call, dbus::ObjectProxy::TIMEOUT_USE_DEFAULT,
- base::Bind(
- &CryptohomeClientImpl::OnBoolMethod,
- weak_ptr_factory_.GetWeakPtr(),
- callback));
+ CallBoolMethod(&method_call, callback);
}
// CryptohomeClient override.
@@ -225,12 +217,7 @@ class CryptohomeClientImpl : public CryptohomeClient {
OVERRIDE {
INITIALIZE_METHOD_CALL(method_call,
cryptohome::kCryptohomePkcs11IsTpmTokenReady);
- proxy_->CallMethod(
- &method_call, dbus::ObjectProxy::TIMEOUT_USE_DEFAULT,
- base::Bind(
- &CryptohomeClientImpl::OnBoolMethod,
- weak_ptr_factory_.GetWeakPtr(),
- callback));
+ CallBoolMethod(&method_call, callback);
}
// CryptohomeClient override.
@@ -335,6 +322,16 @@ class CryptohomeClientImpl : public CryptohomeClient {
return reader.PopBool(result);
}
+ // Calls a method with a bool value result.
+ void CallBoolMethod(dbus::MethodCall* method_call,
+ const BoolMethodCallback& callback) {
+ proxy_->CallMethod(method_call, dbus::ObjectProxy::TIMEOUT_USE_DEFAULT,
+ base::Bind(
+ &CryptohomeClientImpl::OnBoolMethod,
+ weak_ptr_factory_.GetWeakPtr(),
+ callback));
+ }
+
// Handles responses for methods with a bool value result.
void OnBoolMethod(const BoolMethodCallback& callback,
dbus::Response* response) {
@@ -440,9 +437,9 @@ class CryptohomeClientStubImpl : public CryptohomeClient {
}
// CryptohomeClient override.
- virtual bool IsMounted(bool* is_mounted) OVERRIDE {
- *is_mounted = true;
- return true;
+ virtual void IsMounted(const BoolMethodCallback& callback) OVERRIDE {
+ MessageLoop::current()->PostTask(
+ FROM_HERE, base::Bind(callback, DBUS_METHOD_CALL_SUCCESS, true));
}
// CryptohomeClient override.

Powered by Google App Engine
This is Rietveld 408576698