Issue 10817006: Add more FS types and introduce type field into IsolatedContext

Issue 10817006: Add more FS types and introduce type field into IsolatedContext (Closed)

Created:
8 years, 5 months ago by kinuko

Modified:
8 years, 5 months ago

Reviewers:
Lei Zhang, kmadhusu, jam, tzik

CC:
chromium-reviews, mihaip-chromium-reviews_chromium.org, jam, joi+watch-content_chromium.org, Aaron Boodman, darin-cc_chromium.org, oshima+watch_chromium.org, gbillock+watch_chromium.org, smckay+watch_chromium.org, kinuko+watch, stevenjb+watch_chromium.org, nhiroki (google)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add more FS types and introduce type field into IsolatedContext (Separated from a bigger patch: https://chromiumcodereview.appspot.com/10810053) BUG=138022 TEST=existing tests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=148291

Patch Set 1 : #

Patch Set 2 : build fix #

Patch Set 3 : removed Media filesystem type for now #

Total comments: 4

Patch Set 4 : #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+233 lines, -131 lines)			Patch
M	chrome/browser/extensions/api/file_system/file_system_api.cc	View	1	2 chunks	+3 lines, -2 lines	0 comments	Download
M	chrome/browser/extensions/platform_app_launcher.cc	View		2 chunks	+3 lines, -2 lines	0 comments	Download
M	chrome/browser/intents/device_attached_intent_source.cc	View	1 2	2 chunks	+4 lines, -2 lines	0 comments	Download
M	chrome/browser/media_gallery/media_file_system_registry.cc	View	1 2	2 chunks	+3 lines, -2 lines	0 comments	Download
M	content/browser/intents/intent_injector.cc	View		1 chunk	+5 lines, -6 lines	0 comments	Download
M	content/browser/renderer_host/render_view_host_impl.cc	View	1	2 chunks	+4 lines, -2 lines	0 comments	Download
M	webkit/fileapi/file_system_context.cc	View	1 2 3	1 chunk	+1 line, -0 lines	0 comments	Download
M	webkit/fileapi/file_system_types.h	View	1 2	1 chunk	+4 lines, -0 lines	0 comments	Download
M	webkit/fileapi/file_system_util.cc	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	webkit/fileapi/isolated_context.h	View		5 chunks	+65 lines, -27 lines	0 comments	Download
M	webkit/fileapi/isolated_context.cc	View	1 2 3	6 chunks	+108 lines, -71 lines	0 comments	Download
M	webkit/fileapi/isolated_context_unittest.cc	View		3 chunks	+24 lines, -11 lines	0 comments	Download
M	webkit/fileapi/isolated_file_util.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	webkit/fileapi/isolated_file_util_unittest.cc	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	webkit/fileapi/isolated_mount_point_provider.cc	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	webkit/fileapi/obfuscated_file_util.cc	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	webkit/support/webkit_support.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

kinuko

This is the 1st part of change for the refactoring we discussed f2f. PTL thanks,

8 years, 5 months ago (2012-07-24 21:09:08 UTC) #1

tzik

LGTM http://codereview.chromium.org/10817006/diff/10005/webkit/fileapi/file_system_context.cc File webkit/fileapi/file_system_context.cc (right): http://codereview.chromium.org/10817006/diff/10005/webkit/fileapi/file_system_context.cc#newcode126 webkit/fileapi/file_system_context.cc:126: case kFileSystemTypeDragged: Could you move this just above ...

8 years, 5 months ago (2012-07-24 23:15:10 UTC) #2

kinuko

http://codereview.chromium.org/10817006/diff/10005/webkit/fileapi/file_system_context.cc File webkit/fileapi/file_system_context.cc (right): http://codereview.chromium.org/10817006/diff/10005/webkit/fileapi/file_system_context.cc#newcode126 webkit/fileapi/file_system_context.cc:126: case kFileSystemTypeDragged: On 2012/07/24 23:15:11, tzik wrote: > Could ...

8 years, 5 months ago (2012-07-25 00:05:45 UTC) #3

kinuko

thestig@, jam@ could you do the OWNER review? Thanks! thestig@: chrome/ jam@: content/

8 years, 5 months ago (2012-07-25 01:02:41 UTC) #4

lgtm

Expand Messages | Collapse Messages