Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1657)

Unified Diff: chrome/browser/chromeos/bluetooth/bluetooth_device.cc

Issue 10816023: Ensure canonical Bluetooth UUIDs are used. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/bluetooth/bluetooth_device.cc
diff --git a/chrome/browser/chromeos/bluetooth/bluetooth_device.cc b/chrome/browser/chromeos/bluetooth/bluetooth_device.cc
index 57e65d5e952fb846ae058ddfe9f75ea96c7b7696..c3758c0b192c431e84e5389409e9cdc59015cd0e 100644
--- a/chrome/browser/chromeos/bluetooth/bluetooth_device.cc
+++ b/chrome/browser/chromeos/bluetooth/bluetooth_device.cc
@@ -20,6 +20,7 @@
#include "chrome/browser/chromeos/bluetooth/bluetooth_adapter.h"
#include "chrome/browser/chromeos/bluetooth/bluetooth_service_record.h"
#include "chrome/browser/chromeos/bluetooth/bluetooth_socket.h"
+#include "chrome/browser/chromeos/bluetooth/bluetooth_utils.h"
#include "chrome/common/chrome_switches.h"
#include "chromeos/dbus/bluetooth_adapter_client.h"
#include "chromeos/dbus/bluetooth_agent_service_provider.h"
@@ -195,7 +196,7 @@ bool BluetoothDevice::ProvidesServiceWithUUID(const std::string& uuid) const {
const BluetoothDevice::ServiceList& services = GetServices();
for (BluetoothDevice::ServiceList::const_iterator j = services.begin();
j != services.end(); ++j) {
satorux1 2012/07/24 18:29:21 nit: using 'j' for iterator is unusual. rename it
bryeung 2012/07/24 19:50:09 Done.
- if (*j == uuid)
+ if (bluetooth_utils::CanonicalUuid(*j) == uuid)
return true;
}
return false;

Powered by Google App Engine
This is Rietveld 408576698