Ensure canonical Bluetooth UUIDs are used.

Ensure canonical Bluetooth UUIDs are used.

This also fixes a problem with the way error cases were returned:
RunImpl should not call SendResponse when returning false.

TEST=updated api test
BUG=134583
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149746

[bryeung, 2012-07-23 19:23:02]

Antony: for c/b/extensions
Scott: for c/b/chromeos/bluetooth

Thanks!

[asargent_no_longer_on_chrome, 2012-07-23 20:00:43]

LGTM

[satorux1, 2012-07-24 18:29:20]

LGTM with minor suggestions

https://chromiumcodereview.appspot.com/10816023/diff/1/chrome/browser/chromeo...
File chrome/browser/chromeos/bluetooth/bluetooth_device.cc (right):

https://chromiumcodereview.appspot.com/10816023/diff/1/chrome/browser/chromeo...
chrome/browser/chromeos/bluetooth/bluetooth_device.cc:198: j != services.end();
++j) {
nit: using 'j' for iterator is unusual. rename it to 'iter'?

https://chromiumcodereview.appspot.com/10816023/diff/1/chrome/browser/extensi...
File chrome/browser/extensions/api/bluetooth/bluetooth_api.cc (right):

https://chromiumcodereview.appspot.com/10816023/diff/1/chrome/browser/extensi...
chrome/browser/extensions/api/bluetooth/bluetooth_api.cc:116: std::string uuid =
"";
nit: you can remove = "";

https://chromiumcodereview.appspot.com/10816023/diff/1/chrome/browser/extensi...
File chrome/browser/extensions/api/bluetooth/bluetooth_apitest_chromeos.cc
(right):

https://chromiumcodereview.appspot.com/10816023/diff/1/chrome/browser/extensi...
chrome/browser/extensions/api/bluetooth/bluetooth_apitest_chromeos.cc:210:
EXPECT_FALSE(error.empty());
would it make sense to check the error contents with EXPECT_EQ()?

[bryeung, 2012-07-24 19:50:09]

Thanks Satoru!

https://chromiumcodereview.appspot.com/10816023/diff/1/chrome/browser/chromeo...
File chrome/browser/chromeos/bluetooth/bluetooth_device.cc (right):

https://chromiumcodereview.appspot.com/10816023/diff/1/chrome/browser/chromeo...
chrome/browser/chromeos/bluetooth/bluetooth_device.cc:198: j != services.end();
++j) {
On 2012/07/24 18:29:21, satorux1 wrote:
> nit: using 'j' for iterator is unusual. rename it to 'iter'?

Done.

https://chromiumcodereview.appspot.com/10816023/diff/1/chrome/browser/extensi...
File chrome/browser/extensions/api/bluetooth/bluetooth_api.cc (right):

https://chromiumcodereview.appspot.com/10816023/diff/1/chrome/browser/extensi...
chrome/browser/extensions/api/bluetooth/bluetooth_api.cc:116: std::string uuid =
"";
On 2012/07/24 18:29:21, satorux1 wrote:
> nit: you can remove = "";

Done.

https://chromiumcodereview.appspot.com/10816023/diff/1/chrome/browser/extensi...
File chrome/browser/extensions/api/bluetooth/bluetooth_apitest_chromeos.cc
(right):

https://chromiumcodereview.appspot.com/10816023/diff/1/chrome/browser/extensi...
chrome/browser/extensions/api/bluetooth/bluetooth_apitest_chromeos.cc:210:
EXPECT_FALSE(error.empty());
On 2012/07/24 18:29:21, satorux1 wrote:
> would it make sense to check the error contents with EXPECT_EQ()?

Doesn't really seem worthwhile: I don't think it adds that much safety but it
requires moving the error constants to a worse position.

[bryeung, 2012-08-02 18:59:37]

Scott: I had Satoru review this while you were traveling, but need your review
for OWNERS now.  Thanks.

[keybuk, 2012-08-02 22:03:37]

lgtm

[commit-bot: I haz the power, 2012-08-02 22:26:15]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bryeung@chromium.org/10816023/11001

[commit-bot: I haz the power, 2012-08-02 23:49:29]

Change committed as 149746