Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(388)

Issue 10816009: SetBounds even when size didn't change. (Closed)

Created:
8 years, 5 months ago by disher
Modified:
8 years, 5 months ago
Reviewers:
oshima, sky
CC:
chromium-reviews, sadrul, ben+watch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

SetBounds even when size didn't change. This early return would cause us to not properly move the XWindow when the display configuration changes. This would, for example, result in a black remaining display after detaching an external primary display. BUG=chromium-os:31901 TEST=Manually tested on Lumpy to verify that unplugging an external display does correctly switch the aura_root_0 XWindow back to the internal display. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=147888

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -5 lines) Patch
M ui/aura/root_window_host_linux.cc View 2 chunks +2 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
disher
8 years, 5 months ago (2012-07-20 18:04:28 UTC) #1
oshima
lgtm thank you for the fix.
8 years, 5 months ago (2012-07-20 18:20:43 UTC) #2
Daniel Erat
lgtm
8 years, 5 months ago (2012-07-23 14:57:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/disher@chromium.org/10816009/1
8 years, 5 months ago (2012-07-23 15:01:33 UTC) #4
commit-bot: I haz the power
Presubmit check for 10816009-1 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 5 months ago (2012-07-23 15:01:36 UTC) #5
disher
Adding sky@ for OWNERS (thought derat@ was in this directory).
8 years, 5 months ago (2012-07-23 15:04:17 UTC) #6
sky
LGTM
8 years, 5 months ago (2012-07-23 16:13:06 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/disher@chromium.org/10816009/1
8 years, 5 months ago (2012-07-23 17:09:02 UTC) #8
commit-bot: I haz the power
8 years, 5 months ago (2012-07-23 18:33:22 UTC) #9
Change committed as 147888

Powered by Google App Engine
This is Rietveld 408576698