Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9369)

Unified Diff: chrome/nacl/nacl_ipc_adapter.h

Issue 10815087: Change NaClIPCAdapter to save translated descriptors to the rewritten message. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/nacl/nacl_ipc_adapter.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/nacl/nacl_ipc_adapter.h
===================================================================
--- chrome/nacl/nacl_ipc_adapter.h (revision 148428)
+++ chrome/nacl/nacl_ipc_adapter.h (working copy)
@@ -126,9 +126,6 @@
// message, so we don't need to worry about arbitrary message boundaries.
std::string to_be_sent_;
- // Wrapped descriptors and handles for transfer to untrusted code.
- ScopedVector<nacl::DescWrapper> nacl_descs_;
-
bool channel_closed_;
};
@@ -143,8 +140,8 @@
virtual ~NaClIPCAdapter();
- // Reads up to the given amount of data. Returns 0 if nothing is waiting.
- int LockedReceive(char* output_buffer, size_t output_buffer_size);
+ // Returns 0 if nothing is waiting.
+ int LockedReceive(NaClImcTypedMsgHdr* msg);
// Sends a message that we know has been completed to the Chrome process.
bool SendCompleteMessage(const char* buffer, size_t buffer_len);
@@ -160,7 +157,8 @@
// Saves the message to forward to NaCl. This method assumes that the caller
// holds the lock for locked_data_.
- void SaveMessage(const IPC::Message& message);
+ void SaveMessage(const IPC::Message& message,
+ RewrittenMessage* rewritten_message);
base::Lock lock_;
base::ConditionVariable cond_var_;
« no previous file with comments | « no previous file | chrome/nacl/nacl_ipc_adapter.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698