Issue 10815083: Make dbus file descriptor check dynamic

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10815083: Make dbus file descriptor check dynamic (Closed)

Created:
8 years, 5 months ago by DaveMoore

Modified:
8 years, 5 months ago

Reviewers:
satorux1

CC:
chromium-reviews, Sam Leffler

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Make dbus file descriptor check dynamic Without this change cros builds from outside the chroot can't run tracing code. BUG=None TEST=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=148351

Patch Set 1 #

Patch Set 2 : Remove redundant check #

Patch Set 3 : use && #

Total comments: 2

Patch Set 4 : cleanup #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -13 lines)			Patch
	M	dbus/message.h	View		1 chunk	+1 line, -4 lines	0 comments	Download
	M	dbus/message.cc	View	1 2 3	5 chunks	+18 lines, -9 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

satorux1

8 years, 5 months ago (2012-07-24 21:49:08 UTC) #2

LGTM with nits:

http://codereview.chromium.org/10815083/diff/4001/dbus/message.cc
File dbus/message.cc (right):

http://codereview.chromium.org/10815083/diff/4001/dbus/message.cc#newcode40
dbus/message.cc:40: bool IsDBusTypeUnixFdSupported() {
It's not obvious why we should check this run time. maybe add something like:

// Returns true if Unix FD passing is supported in libdbus.
// The check is done runtime rather than compile time as the libdbus
// version used at runtime may be different from the one used at compile time.

http://codereview.chromium.org/10815083/diff/4001/dbus/message.cc#newcode41
dbus/message.cc:41: int major, minor, micro;
nit: initialize them with 0 just in case.

Expand Messages | Collapse Messages